Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes "unexpected application error" thrown in the shop/item/itemID and shop/checkout pages #206

Conversation

alvyynm
Copy link
Member

@alvyynm alvyynm commented Jun 22, 2024

Have you read the contributing guidelines ?

What is the purpose of your pull request?

  • Bug fix
  • New feature

Proposed changes

This PR updates Mutations in hooks/Mutations/shop to use tanstack-query v5 syntax. V4 syntax was causing issues in /shop/item/itemID and shop/checkout pages (the infamous e(...).defaultMutationOptions is not a function error.

This PR effectively fixes #205.

Warning

Please read these points carefully and answer honestly with an X
into all the boxes. Example : [X]

Before submitting a pull request make sure you have:

  • Read the guidelines for contributing.
  • Wrote some tests.
  • Respected the linting guidelines.

@alvyynm alvyynm added the bug Something isn't working label Jun 22, 2024
@alvyynm alvyynm self-assigned this Jun 22, 2024
@alvyynm alvyynm linked an issue Jun 22, 2024 that may be closed by this pull request
Copy link

vercel bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syt-web-redesign ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 11:28am

@alvyynm alvyynm marked this pull request as ready for review June 22, 2024 11:30
@alvyynm alvyynm requested a review from sonylomo June 22, 2024 11:30
@alvyynm alvyynm changed the title 205 unexpected application error edefaultmutationoptions is not a function thrown in the single item view page Fixes "unexpected application error" thrown in the shop/item/itemID and shop/checkout pages Jun 22, 2024
@bridgitkanini bridgitkanini self-requested a review June 25, 2024 12:15
@sonylomo sonylomo merged commit 73821c5 into Dev Jul 2, 2024
3 of 4 checks passed
@sonylomo sonylomo deleted the 205-unexpected-application-error-edefaultmutationoptions-is-not-a-function-thrown-in-the-single-item-view-page branch July 2, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unexpected Application Error" thrown in the Single Item View page
3 participants