fix(ffe-system-message-react): SystemMessageProps now extends React.C… #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1930.westeurope.2.azurestaticapps.net |
pethel
suggested changes
Apr 24, 2024
| @@ -1,6 +1,6 @@ | |||
| import * as React from 'react'; | |||
|
|
|||
| export interface SystemMessageProps { | |||
There was a problem hiding this comment.
usen takk for ditt bidrag.
Da kan man fjerne className og children, iaf som er en del av React.ComponentProps<'div'>
Ser også ut som vi ikke har en ref. Så det blir vell mest riktigt her att bruke ComponentPropsWithoutRef. tenker hele kan vare slik. enig?
export interface SystemMessageProps extends React.ComponentPropsWithoutRef<'div'> {
animationLengthMs?: number;
icon?: React.ReactNode;
locale?: 'en' | 'nb' | 'nn';
onClose?: React.MouseEventHandler<HTMLButtonElement>;
onColoredBg?: boolean;
}
…omponentProps<'div'>
SaraElisabethIdris
force-pushed
the
develop_fix-system-message-props
branch
from
957ac59 to
c25746f
Compare
pethel
approved these changes
Apr 24, 2024
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1930.westeurope.2.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…omponentProps<'div'>
La til extends React.ComponentProps<'div'> for at man skal kunne ha JSX elementer inni.
Testing
Testet lokalt