Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ffe-accordion-react): use context for accordion item props #1943

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

pethel
Copy link
Contributor

@pethel pethel commented Apr 25, 2024

Sett denne hundefined 1000 ganger nå tror jag. Tenker er en context vill løsa det problemet.

image

@pethel pethel requested a review from a team as a code owner April 25, 2024 12:38
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1943.westeurope.2.azurestaticapps.net

@pethel pethel force-pushed the develop_fix-accordion branch from 29beade to 97ac959 Compare April 25, 2024 12:45
Some times the consumers need to put something in between Accordion and AccordionItem.
This will lead to bugs if the consumer is not careful about passing the props
through their own component in between. With a context there is no need to worry about this.
@pethel pethel force-pushed the develop_fix-accordion branch from 97ac959 to 361a8e7 Compare April 25, 2024 13:04
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1943.westeurope.2.azurestaticapps.net

@pethel pethel merged commit 39bb78c into develop Apr 26, 2024
3 checks passed
@pethel pethel deleted the develop_fix-accordion branch April 26, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants