Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop fix checkbox hidden label uu #1944

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

pethel
Copy link
Contributor

@pethel pethel commented Apr 25, 2024

Mitt føslag på løsning av uu feil med hiddenLabel. Måtte bli en breaking change i så fall.

Løser denne. #1712

image

@pethel pethel requested a review from a team as a code owner April 25, 2024 14:01
@pethel pethel force-pushed the develop_fix-checkbox-hidden-label-uu branch from 66362e1 to 765530f Compare April 25, 2024 14:02
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1944.westeurope.2.azurestaticapps.net

1 similar comment
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1944.westeurope.2.azurestaticapps.net

@HeleneKassandra
Copy link
Contributor

HeleneKassandra commented Apr 29, 2024

Skriv gjerne en melding i kanalen der du informerer om denne breaking changen og hva folk må oppdatere

Peter Hellstrand added 2 commits April 29, 2024 11:28
…heckbox

BREAKING CHANGE: children is now required also when using hiddenLabel.
When hiddenLabel is set to true children will just be visible to screen readers.
@pethel pethel force-pushed the develop_fix-checkbox-hidden-label-uu branch from 765530f to 412c649 Compare April 29, 2024 09:31
@pethel pethel requested a review from HeleneKassandra April 29, 2024 09:31
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1944.westeurope.2.azurestaticapps.net

@pethel pethel merged commit c3d4a08 into develop Apr 29, 2024
3 checks passed
@pethel pethel deleted the develop_fix-checkbox-hidden-label-uu branch April 29, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants