Develop remove default props #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pethel
force-pushed
the
develop_remove-default-props
branch
from
d68aab8 to
285416c
Compare
added 14 commits
April 28, 2024 13:47
pethel
force-pushed
the
develop_remove-default-props
branch
from
285416c to
9dced76
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-1950.westeurope.2.azurestaticapps.net |
| AccountSelectorMulti.defaultProps = { | ||
| onSelectAll: () => {}, | ||
| selectedAccounts: [], | ||
| showSelectAllOption: false, |
There was a problem hiding this comment.
Bør denne fjernes i fjernes i index.d.ts fila også?
There was a problem hiding this comment.
Jag fant inget bruk av den, men turte ikke fjerne. Tok sjansen på att false og undefined vill opføra seg likt her.
HeleneKassandra
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fjerner default props slik att man kan bruke react 19.
https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-deprecated-react-apis