Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legg til muligheten for 2 ikoner og ikon på høyre side i StippledCard #2429

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Legg til muligheten for 2 ikoner og ikon på høyre side i StippledCard #2429

merged 2 commits into from
Nov 28, 2024

Conversation

HeleneKassandra
Copy link
Contributor

Beskrivelse

Legger til rightImg-prop som lar brukerne legge til ett ikon som plasseres på høyreside av kortet.
I tillegg åpner jeg for at man kan sende med 2 ikoner i samme kort.
Legger også til stories som viser hvordan det funker i storybook.

Motivasjon og kontekst

Det er veldig mange steder i Oversikt (og andre steder) der det brukes en variant av stippledCard og IconCard med 2 ikoner.
Håper derfor vi kan få det inn i FFE, sånn at man slipper å gjøre spesial tilpasninger hver gang det dukker opp i designet.

Viser seg også at dette er mulig i figma allerede.

Testing

Kjørt opp lokalt og sett at det funker i Storybook.

@HeleneKassandra HeleneKassandra requested a review from a team as a code owner November 28, 2024 13:34
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2429.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra force-pushed the stippledcard-legg-til-righticon branch 2 times, most recently from 950e7ed to 4ee11e4 Compare November 28, 2024 13:44
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2429.westeurope.2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2429.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra force-pushed the stippledcard-legg-til-righticon branch from 4ee11e4 to b33f976 Compare November 28, 2024 14:25
pethel
pethel previously approved these changes Nov 28, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2429.westeurope.2.azurestaticapps.net

@HeleneKassandra
feat(ffe-cards-react): legg til rightImg-prop
693118a 
legger til muligheten til å ha ikon på høyreside, og for at man kan ha 2 ikoner i samme kort
@HeleneKassandra HeleneKassandra force-pushed the stippledcard-legg-til-righticon branch from b33f976 to 9d7c4f5 Compare November 28, 2024 14:31
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2429.westeurope.2.azurestaticapps.net

@HeleneKassandra HeleneKassandra force-pushed the stippledcard-legg-til-righticon branch from 9d7c4f5 to 8ac543e Compare November 28, 2024 14:39
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2429.westeurope.2.azurestaticapps.net

@pethel pethel merged commit 7bde55a into develop Nov 28, 2024
3 checks passed
@antidecaf antidecaf deleted the stippledcard-legg-til-righticon branch March 3, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pethel pethel pethel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeleneKassandra @pethel