Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube support #75

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Youtube support #75

wants to merge 11 commits into from

Conversation

sidit77
Copy link
Contributor

@sidit77 sidit77 commented Aug 1, 2023

This PR add support for YouTube just like mentioned in #74. I switched from using the API of a Piped instance (which could go down or get overloaded) to using the NewPipeExtractor library to extract the videos directly on the device.

Remaining Issues:

  • Support resolutions higher than 720p (this means implementing the abillity to load an external audio track)
  • Improve the conditional compilation? Idk, my current approach feel very unclean (still has youtube link handling in the manifest for example) but I'm unsure how to improve it without making everything much more complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant