Task/aa 3297 create awaiting reimbursement item #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Scythe14
commented
Jan 30, 2024
Scythe14
commented
RomainGF
requested changes
Jan 30, 2024
| val gaugeDelimiterWidth: Dp = 2.dp | ||
| val gaugeDelimiterWidth: Dp = 2.dp, | ||
|
|
||
| val grapesStackSurface: Dp = 36.dp |
There was a problem hiding this comment.
This dimension is not intended to be reused elsewhere than in the composable, so it must stay at the composable level. We should try to keep only these dimensions here : https://www.figma.com/file/fiCb2Cltq1gJuByGKvxLNb/%F0%9F%8D%87--Design-Tokens?type=design&node-id=2978-20087&mode=design&t=AcLTEy1QplJFUZTk-4
RomainGF
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.