Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/remove legacy registration view #337

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Chore/remove legacy registration view #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
758fbaf
Remove view usage from sample
kelianClerc Feb 8, 2024
c9bdbe7
Remove legacy RegistrationCodeView and all resources
kelianClerc Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 0 additions & 123 deletions library/src/main/java/com/spendesk/grapes/RegistrationCodeView.kt
View file
Open in desktop

This file was deleted.

80 changes: 0 additions & 80 deletions library/src/main/res/layout/view_registration_code.xml
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions library/src/main/res/values-hdpi/dimens.xml
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions library/src/main/res/values-v26/styles.xml
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions library/src/main/res/values-xhdpi/dimens.xml
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions library/src/main/res/values/colors.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,14 +136,6 @@
<color name="toasterText">@color/mainWhite</color>
<!-- endregion Toaster -->

<!-- region Security Code Validation CardView -->

<color name="registrationCodeViewBackground">@color/colorPrimaryDark</color>
<color name="registrationCodeViewTextColor">@color/mainWhite</color>
<color name="registrationCodeViewSeparatorViewBackground">@color/mainWhite</color>

<!-- endregion Security Code Validation CardView -->

<!-- region NumberKeyboardText -->

<color name="numberKeyboardTextColorLight">@color/mainWhite</color>
Expand Down
14 changes: 0 additions & 14 deletions library/src/main/res/values/dimens.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,20 +88,6 @@

<!-- endregion Chip -->

<!-- region Security Code Validation CardView -->

<dimen name="registrationCodeViewContainerHeight">56dp</dimen>
<dimen name="registrationCodeViewCardRadius">12dp</dimen>
<dimen name="registrationCodeViewCardElevation">0dp</dimen>
<dimen name="registrationCodeViewTextLetterSpacing">0.35</dimen>
<dimen name="registrationCodeViewTextSize">24sp</dimen>

<dimen name="registrationCodeSeparatorWidth">8dp</dimen>
<dimen name="registrationCodeSeparatorHeight">2dp</dimen>
<dimen name="registrationCodeMarginHorz">8dp</dimen>

<!-- endregion Security Code Validation CardView -->

<!-- Verification Code View -->

<dimen name="pinCodeDotViewItemSize">16dp</dimen>
Expand Down
22 changes: 0 additions & 22 deletions library/src/main/res/values/styles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,28 +230,6 @@

<!-- endregion Toaster -->

<!-- region Security Code Validation CardView -->

<style name="RegistrationCodeViewText">
<item name="android:focusable">true</item>
<item name="android:fontFamily">@font/gt_america</item>
<item name="android:textCursorDrawable">@null</item>
<item name="android:background">@null</item>
<item name="android:hint">@null</item>
<item name="android:gravity">center</item>
<item name="android:inputType">numberPassword|textNoSuggestions</item>
<item name="android:digits">0123456789</item>
<item name="android:letterSpacing">@dimen/registrationCodeViewTextLetterSpacing</item>
<item name="android:textSize">@dimen/registrationCodeViewTextSize</item>
<item name="android:textColor">@color/registrationCodeViewTextColor</item>
</style>

<style name="RegistrationCodeViewSeparatorView">
<item name="android:background">@color/registrationCodeViewSeparatorViewBackground</item>
</style>

<!-- endregion Security Code Validation CardView -->

<!-- region NumberKeyboardText -->

<style name="NumberKeyboardText">
Expand Down
46 changes: 1 addition & 45 deletions sample/src/main/res/layout/fragment_home_cards.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,50 +208,6 @@
app:layout_constraintTop_toBottomOf="@+id/homeCardSectionPlasticCardAlertSubtitle" />
</androidx.constraintlayout.widget.ConstraintLayout>
</com.spendesk.grapes.BucketView>

<com.spendesk.grapes.BucketView
android:id="@+id/homeCardSectionRegistrationCodeBucketView"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_marginStart="@dimen/homeSectionBucketViewMarginHorz"
android:layout_marginTop="@dimen/homeSectionBucketViewMarginVert"
android:layout_marginEnd="@dimen/homeSectionBucketViewMarginHorz"
android:layout_marginBottom="@dimen/homeSectionBucketViewMarginVert"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@id/homeCardSectionPlasticCardBucketView">

<androidx.constraintlayout.widget.ConstraintLayout
android:layout_width="match_parent"
android:layout_height="match_parent">

<TextView
android:id="@+id/homeCardSectionRegistrationCodeNormalSubtitle"
style="@style/HomeGenericSubtitle"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_marginStart="@dimen/homeSectionSubtitleMarginHorz"
android:layout_marginTop="@dimen/homeSectionSubtitleMarginVert"
android:layout_marginEnd="@dimen/homeSectionSubtitleMarginHorz"
android:text="@string/cardNormal"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />

<com.spendesk.grapes.RegistrationCodeView
android:layout_width="0dp"
android:layout_height="56dp"
android:layout_marginStart="@dimen/homeSectionSubtitleMarginHorz"
android:layout_marginTop="@dimen/homeSectionSubtitleMarginVert"
android:layout_marginEnd="@dimen/homeSectionSubtitleMarginHorz"
android:layout_marginBottom="@dimen/homeSectionSubtitleMarginVert"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@+id/homeCardSectionRegistrationCodeNormalSubtitle" />
</androidx.constraintlayout.widget.ConstraintLayout>
</com.spendesk.grapes.BucketView>
<!-- endregion plastic card -->
</androidx.constraintlayout.widget.ConstraintLayout>
</ScrollView>
</ScrollView>
Loading