Feature/sprind 116

[zoemaas]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.11%. Comparing base (8b78e93) to head (642c60b).
Report is 18 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #169   +/-   ##
========================================
  Coverage    48.11%   48.11%           
========================================
  Files           75       75           
  Lines         5175     5175           
  Branches      1761     1800   +39     
========================================
  Hits          2490     2490           
  Misses        2682     2682           
  Partials         3        3           

Flag	Coverage Δ
unittest	48.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ronal2do]

make make it more functional, and split the logic on it for something like

Suggested change

	public static async parseAndResolve(uri: string, rpRegistrationMetadata?: RPRegistrationMetadataPayload) {
	/**
	* Parses the URI and resolves the registration metadata
	* @param uri
	* @param rpRegistrationMetadata
	* @returns Promise<{scheme: string, authorizationRequestPayload: AuthorizationRequestPayload, requestObjectJwt: RequestObjectJwt, registrationMetadata: RPRegistrationMetadataPayload}>
	*/
	public static async parseAndResolve(uri: string, rpRegistrationMetadata?: RPRegistrationMetadataPayload) {
	if (!uri) {
	throw Error(SIOPErrors.BAD_PARAMS)
	}
	const { authorizationRequestPayload, scheme } = this.parse(uri)
	const requestObjectJwt = await fetchByReferenceOrUseByValue(
	authorizationRequestPayload.client_metadata_uri,
	authorizationRequestPayload.client_metadata
	)
	const registrationMetadata = await this.resolveRegistrationMetadata(
	rpRegistrationMetadata,
	authorizationRequestPayload,
	)
	assertValidRPRegistrationMedataPayload(registrationMetadata)
	return { scheme, authorizationRequestPayload, requestObjectJwt, registrationMetadata }
	}
	/**
	* Resolves the registration metadata
	* @param providedMetadata
	* @param authPayload
	* @returns Promise<RPRegistrationMetadataPayload>
	*/
	private static async resolveRegistrationMetadata(
	providedMetadata?: RPRegistrationMetadataPayload,
	authPayload?: AuthorizationRequestPayload
	): Promise<RPRegistrationMetadataPayload> {
	if (providedMetadata) {
	return providedMetadata
	}
	return await fetchByReferenceOrUseByValue(
	authPayload?.['client_metadata_uri'] ?? authPayload?.['registration_uri'],
	authPayload?.['client_metadata'] ?? authPayload?.['registration']
	)
	}

[ronal2do]

code wise looks fine with an small remark