feature/SPRIND-137 #174
feature/SPRIND-137 #174
Conversation
Signed-off-by: Timo Glastra <timo@animo.id>
# Conflicts: # packages/siop-oid4vp/lib/authorization-request/AuthorizationRequest.ts # packages/siop-oid4vp/lib/authorization-response/OpenID4VP.ts # packages/siop-oid4vp/package.json # pnpm-lock.yaml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #174 +/- ##
========================================
Coverage 48.11% 48.11%
========================================
Files 75 75
Lines 5175 5175
Branches 1800 1800
========================================
Hits 2490 2490
Misses 2682 2682
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # pnpm-lock.yaml
…ID4VC into feature/SPRIND-137
… pass in a SIOPv2_D12_OID4VP_D20 version request
# Conflicts: # package.json # packages/siop-oid4vp/lib/rp/RPBuilder.ts # pnpm-lock.yaml
…ID4VC into feature/VDX-341_dcql
| @@ -19,7 +19,7 @@ | |||
| "@sphereon/oid4vci-client": "workspace:*", | |||
| "@sphereon/oid4vci-common": "workspace:*", | |||
| "@sphereon/oid4vci-issuer": "workspace:*", | |||
| "@sphereon/ssi-types": "0.30.2-feature.mdoc.funke2.367", | |||
| "@sphereon/ssi-types": "0.32.1-feature.VDX.341.53", | |||
There was a problem hiding this comment.
This needs to be addressed. (For all instances of this branch)
Maybe it's best to create a separate PR for ssi-types, merged it, then use it in this repo, merge this one then SSI-SDK.
There was a problem hiding this comment.
I will create a follow-up PR when SSI-SDK is merged. But first we need to merge this PR because SSI-SDK also depends on this project to a greater extend.
| @@ -23,7 +23,8 @@ | |||
| "node": ">=18" | |||
| }, | |||
| "resolutions": { | |||
| "@sphereon/ssi-types": "0.30.2-feature.mdoc.funke2.367", | |||
| "@sphereon/ssi-types": "0.32.1-feature.VDX.341.53", | |||
There was a problem hiding this comment.
just wondering if we will keep working with packages with branch-names, after merge to developer we might fix it
There was a problem hiding this comment.
I will take care of it, see other tickets
packages/siop-oid4vp/lib/__tests__/AuthenticationResponse.response.spec.ts
Outdated
Show resolved
Hide resolved
| throw new Error(SIOPErrors.REQUEST_CLAIMS_PRESENTATION_DEFINITION_NOT_VALID) | ||
|
|
||
| if (opts.vp_token.presentation_definition || opts.vp_token.presentation_definition_uri) { | ||
| const discoveryResult = PEX.definitionVersionDiscovery(opts.vp_token.presentation_definition) |
There was a problem hiding this comment.
I'll approve while waiting for @nklomp input here
|
approved |
No description provided.