Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sd-jwt): cnf instead of kid #83

Merged

Conversation

TimoGlastra
Copy link
Collaborator

small fix to use cnf object instead of sub property for binding the sd-jwt as defined in the sd-jwt vc spec.

Also adds support for kid (did) binding in addition to jwk binding for an sd-jwt

TimoGlastra and others added 3 commits January 11, 2024 13:34
Signed-off-by: Timo Glastra <timo@animo.id>
Remove note
chore: missed to remove actual es-line line
Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nklomp and others added 2 commits January 11, 2024 09:22
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra
Copy link
Collaborator Author

updated with latest ssi-types

@nklomp nklomp merged commit b3f0cf1 into Sphereon-Opensource:develop Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants