chore: removed well-known vct url location requirement

Sphereon-Opensource · Dec 6, 2024 · ab5cf6c · ab5cf6c
1 parent 657f6b5
commit ab5cf6c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/packages/oid4vci-holder/src/agent/OID4VCIHolderService.ts b/packages/oid4vci-holder/src/agent/OID4VCIHolderService.ts
@@ -1,8 +1,8 @@
 import { LOG } from '@sphereon/oid4vci-client'
 import {
   CredentialConfigurationSupported,
-  // CredentialSupportedSdJwtVc,
-  // CredentialConfigurationSupportedSdJwtVcV1_0_13,
+  CredentialSupportedSdJwtVc,
+  CredentialConfigurationSupportedSdJwtVcV1_0_13,
   CredentialOfferFormatV1_0_11,
   CredentialResponse,
   getSupportedCredentials,
@@ -70,11 +70,11 @@ export const getCredentialBranding = async (args: GetCredentialBrandingArgs): Pr
     Object.entries(credentialsSupported).map(async ([configId, credentialsConfigSupported]): Promise<void> => {
       let sdJwtTypeMetadata: SdJwtTypeMetadata | undefined
       if (credentialsConfigSupported.format === 'vc+sd-jwt') {
-        const vct = "https://raw.githubusercontent.com/Sphereon-Opensource/vc-contexts/refs/heads/master/funke/sd-jwt-metadata/age_group.json"//(<CredentialSupportedSdJwtVc | CredentialConfigurationSupportedSdJwtVcV1_0_13>credentialsConfigSupported).vct
+        const vct = (<CredentialSupportedSdJwtVc | CredentialConfigurationSupportedSdJwtVcV1_0_13>credentialsConfigSupported).vct
         if (vct.startsWith('http')) {
           try {
             sdJwtTypeMetadata = await context.agent.fetchSdJwtTypeMetadataFromVctUrl({ vct })
-          } catch (error) {
+          } catch {
             // For now, we are just going to ignore and continue without any branding as we still have a fallback
           }
         }

diff --git a/packages/sd-jwt/src/action-handler.ts b/packages/sd-jwt/src/action-handler.ts
@@ -348,9 +348,8 @@ export class SDJwtPlugin implements IAgentPlugin {
   async fetchSdJwtTypeMetadataFromVctUrl(args: FetchSdJwtTypeMetadataFromVctUrlArgs, context: IRequiredContext): Promise<SdJwtTypeMetadata> {
     const {vct, opts} = args
     const url = new URL(vct)
-    const wellKnownUrl = `${url.origin}/.well-known/vct${url.pathname}`
 
-    const response = await fetchUrlWithErrorHandling(wellKnownUrl)
+    const response = await fetchUrlWithErrorHandling(url.toString())
     const metadata: SdJwtTypeMetadata = await response.json()
     assertValidTypeMetadata(metadata, vct)