Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/SPRIND-89 #300

Merged
merged 33 commits into from
Jan 24, 2025
Merged

feature/SPRIND-89 #300

merged 33 commits into from
Jan 24, 2025

Conversation

BtencateSphereon
Copy link
Contributor

No description provided.

@BtencateSphereon BtencateSphereon changed the title feat/SPRIND-89 feature/SPRIND-89 Jan 9, 2025
# Conflicts:
#	packages/ebsi-support/package.json
#	packages/mdl-mdoc/package.json
#	packages/oid4vci-holder/package.json
#	packages/oid4vci-issuer-rest-api/package.json
#	packages/oid4vci-issuer-rest-client/package.json
#	packages/oid4vci-issuer-store/package.json
#	packages/oid4vci-issuer/package.json
#	packages/siopv2-oid4vp-common/package.json
#	packages/siopv2-oid4vp-op-auth/package.json
#	packages/siopv2-oid4vp-rp-auth/package.json
#	packages/siopv2-oid4vp-rp-rest-api/package.json
#	packages/w3c-vc-api/package.json
#	pnpm-lock.yaml
@BtencateSphereon BtencateSphereon marked this pull request as ready for review January 16, 2025 12:36
@BtencateSphereon BtencateSphereon marked this pull request as draft January 16, 2025 12:59
@BtencateSphereon BtencateSphereon marked this pull request as ready for review January 16, 2025 13:06
Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small remarks. Similar like in the low-level lib about the is first party being tucked in the response.

Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BtencateSphereon BtencateSphereon merged commit 3b988a2 into develop Jan 24, 2025
2 checks passed
@BtencateSphereon BtencateSphereon deleted the feature/SPRIND-89 branch January 24, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants