Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/CWALL-166 #45

Merged
merged 15 commits into from
Apr 29, 2024
Merged

feature/CWALL-166 #45

merged 15 commits into from
Apr 29, 2024

Conversation

BtencateSphereon
Copy link
Collaborator

No description provided.

@BtencateSphereon
Copy link
Collaborator Author

BtencateSphereon commented Apr 24, 2024

@nklomp can you take a look at the lockfile issue, there seem to be an issue with the ci version of pnpm against the local one. I tried, 8.6.0 and 9.0.6

@nklomp
Copy link
Contributor

nklomp commented Apr 25, 2024

@BtencateSphereon Fixed, but still doesn't build. Except that is an issue in this branch it seems. I cherry picked the CI/CD changes to develop and my expo-20 branch as well and they both build fine

…ature/CWALL-166

# Conflicts:
#	packages/ssi-react/src/index.ts
#	packages/ssi-react/src/styles/components/components/SSICheckbox/index.ts
#	packages/ssi-react/src/styles/components/components/index.ts
#	pnpm-lock.yaml
@BtencateSphereon BtencateSphereon changed the base branch from develop to feature/expo-20 April 25, 2024 10:25
Base automatically changed from feature/expo-20 to develop April 25, 2024 11:34
Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BtencateSphereon BtencateSphereon merged commit 8dbfe8d into develop Apr 29, 2024
2 checks passed
@BtencateSphereon BtencateSphereon deleted the feature/CWALL-166 branch April 29, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants