Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add package manager to npm package.json #39

Open
wants to merge 1 commit into
base: feature/surf
Choose a base branch
from

Conversation

berkes
Copy link

@berkes berkes commented Jan 29, 2025

This ensures all devs use pnpm and use the same version. The README explains we must use pnpm (but not the version).
It picks a recent stable version and pins that.
Other devs running other versions will now get an error.

Running a recent pnpm version will add this attribute. So if not added now, a future commit may add this accidentally or devs will need to ignore and revert this all the time.

This increases reproducability of builds

This ensures all devs use pnpm and use the same version. The README
explains we must use pnpm (but not the version).
It picks a recent stable version and pins that.
Other devs running other versions will now get an error.

Running a recent pnpm version will add this attribute. So if not added
now, a future commit may add this accidentally or devs will need to
ignore and revert this all the time.

This increases reproducability of builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant