Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STAC-21861: Produce metric to track the usage of traces #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aacevedoosorio
Copy link
Contributor

No description provided.

meter := metadata.Meter(set)
tracesBytesCounter, _ := meter.Int64Counter(
"suse_observability_usage_bytes_accepted_traces",
metric.WithDescription("Number of spans dropped when trying to add edges"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the description does not seem to be in line with the metric

}

func newTracesExporter(logger *zap.Logger, cfg *Config) (*tracesExporter, error) {
func newTracesExporter(logger *zap.Logger, set component.TelemetrySettings, cfg *Config) (*tracesExporter, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the exporter is quite late in the pipeline - so the metric will not precisely reflect how much data entered the system. It may be good enough for now, but maybe we should have a receiver handling the accounting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can move the code to a new receiver. So perhaps if we prefer I do it already ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants