Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing swiftlint package dependency #46

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Sep 2, 2024

Fixed missing swiftlint package dependency

♻️ Current situation & Problem

The Package manifest was missing adding swiftlint as a package dependency. This resulted in failing to load the package if one enabled the SPEZI_DEVELOPMENT_SWIFTLINT environment variable.

⚙️ Release Notes

  • Fixed missing swiftlint package dependency.

📚 Documentation

--

✅ Testing

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.71%. Comparing base (c24e316) to head (4c4c4d7).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   92.80%   92.71%   -0.09%     
==========================================
  Files          23       23              
  Lines        1097     1097              
==========================================
- Hits         1018     1017       -1     
- Misses         79       80       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c24e316...4c4c4d7. Read the comment docs.

@PSchmiedmayer
Copy link
Member

Oh, my bad, thank you!

@Supereg Supereg merged commit 87a9257 into main Sep 2, 2024
9 checks passed
@Supereg Supereg deleted the fix/swiftlint-dependency branch September 2, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants