DeviceStateAccessor: fix incorrect initial parameter propagation; restore ability to connect to devices
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
superseded by #53 |
lukaskollmer
added a commit
that referenced
this pull request
Nov 23, 2024
…estore ability to connect to devices (#53) ## ♻️ Current situation & Problem Trying to connect (via SpeziDevices) to a peripheral doesn't work because the `nearby.onChange` state observer is sent an initial `false` value, which causes the peripheral to immediately get discarded after being discovered. ## ⚙️ Release Notes - Fix issue that could prevent peripheral connection establishment ## 📚 Documentation n/a ## ✅ Testing n/a ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md). --- Note: this PR supersedes #52 (the difference being that this one is made from an repo-internal branch, which @PSchmiedmayer said was required for some of the actions to properly run)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation & Problem
Trying to connect (via SpeziDevices) to a peripheral doesn't work because the
nearby.onChangestate observer is sent an initialfalsevalue, which causes the peripheral to immediately get discarded after being discovered.⚙️ Release Notes
📚 Documentation
n/a
✅ Testing
n/a
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: