-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/e2e create event #216
Fix/e2e create event #216
Conversation
this is only temporary for testing purposes
…blocking indefinitely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work, I already approve your PR because I only saw a cleaning code issue and a function that needs to be documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Since there is an unused import could you run Optimize Imports, this could be done on Android Studio via Code > Optimize Imports
@@ -40,6 +40,10 @@ open class ParkViewModel( | |||
_currentPark.value = park | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improvement: since setCurrentPark
has a doc could you also add a small function description ?
Quality Gate passedIssues Measures |
Overview
This PR aims to refactor the end to end to create an event by removing all network calls and mocking the database to make it valid
Implementation
This end to end now tests the full functionalities of all repositories and viewmodels called when navigating from the map to a park by clicking on the park overview, as well as creating an event and displaying it on the park overiew
The end to end had to be divided into two parts, I suspect that the CI has some limitations that i am not aware of but the test won't pass on it if it is too long, leaving me only with the choice of making it significantly smaller or dividing it into two parts.
Additionnal info