Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/workout mvvm #223

Closed
wants to merge 7 commits into from
Closed

Fix/workout mvvm #223

wants to merge 7 commits into from

Conversation

tercierp
Copy link
Collaborator

Overview

This PR was created to reduce the size of the code to be reviewed. I had to fix some problems during my implementation of the coaching screen, especially deserialization which crashed the application, and asynchronous problems.

@tercierp tercierp added this to the Milestone M3 milestone Dec 12, 2024
@tercierp tercierp self-assigned this Dec 12, 2024
@tercierp tercierp linked an issue Dec 12, 2024 that may be closed by this pull request
Patch the MVVM workout #222
Closed
@tercierp tercierp added the Enhancement ✨ New feature or request label Dec 12, 2024
@tercierp
Copy link
Collaborator Author

Since I've drastically changed the structure of the training coach, I've decided to reorganize the branches, the relevant branches are #231 , and #232.

@tercierp tercierp closed this Dec 17, 2024
@tercierp tercierp deleted the fix/workout-MVVM branch December 17, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tercierp tercierp

Labels
Enhancement ✨ New feature or request Fixed bug ✅
Projects
None yet
Milestone
Milestone M3
Development

Successfully merging this pull request may close these issues.

Patch the MVVM workout
1 participant
@tercierp