Feat/Finalize and improve the aesthetics of the progression UI #234
Conversation
alvaro1080
changed the title
| @@ -170,6 +170,14 @@ fun ProgressScreen( | |||
| } | |||
| DashboardStateProgression.Training -> { | |||
|
|
|||
| if (currentWorkout?.workoutSessions?.isEmpty() == true) { | |||
There was a problem hiding this comment.
You can put : currentWorkout?.workoutSessions.isNullOrEmpty() instead of a == true check,
Not really important, resolve if you think its fine like this
There was a problem hiding this comment.
I agree that this is better, it is changed thank you!
There was a problem hiding this comment.
The changes look good, the medals are much cleaner.
I approved but here's a few suggestions, I'll let you decide if you want to take them into account or not:
- I find it hard to distinguish the gold and platinum medal. I think have a color similar to this would be better:
- The old icons for the friends are lacking colors compared to the new badges, would be great to update them to something more flashy
| eventsJoined = 0, | ||
| achievements = emptyList()) | ||
|
|
||
| coEvery { progressionRepository.getOrAddProgression(eq(mockedUser.uid)) } answers |
There was a problem hiding this comment.
I see that it has already been done in the file so no need to change, but you should not mix 2 mocking libraries in the same file.
There was a problem hiding this comment.
I apologize, I did not know that it was bad to do that. Thank you for letting me know!
|
I spend quite some time to generate the current set of medals, as a lot of generated images were really bad. In order to keep the coherence of the medals, I will keep theme like this and try to generate a new set in order to match the color you proposed!
I agree, but as per my last comment, I also did not manage to generate something coherent (and beautiful enough) for the friends icons. If I manage to find better for the friends, I will do another PR but I really think that the medals needed to change quickly because the bronze and the platinum had the same logo. |
Overview
The objective of this short Pull request is to finalize the last details of the progression UI.
Changes
Screenshot