Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add image data deletion in account deletion #237

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Feat/add image data deletion in account deletion #237

merged 4 commits into from
Dec 18, 2024

Conversation

Alex720p
Copy link
Contributor

@Alex720p Alex720p commented Dec 17, 2024 •
edited
Loading

This pr adds the image deletion process to the existing account deletion.

How to test:
Upload pictures, rate other user pictures. Delete account and check that your uploads and ratings have been deleted.
There's a picture uploaded here to to check the rating on:
Screenshot 2024-12-17 164124

@Alex720p
refactor: pass the image viewmodel to allow account deletion + bring …
563ebf5 
…back old implementation of ImageRepositoryFirestore::deleteAllDataFromUser
@Alex720p
refactor: add imageViewModel to settings test + bring back ImageRepos…
7f7da75 
…itoryFirestoreTest deleteAllDataFromUser to old version
@Alex720p Alex720p linked an issue Dec 17, 2024 that may be closed by this pull request
Implement the deletion of all user related image in the existing account deletion #236
Closed
1 task
@Alex720p Alex720p self-assigned this Dec 17, 2024
@Alex720p Alex720p added the Enhancement ✨ New feature or request label Dec 17, 2024
@Alex720p Alex720p added this to the Milestone M3 milestone Dec 17, 2024
@SaturneV SaturneV self-requested a review December 17, 2024 17:57
SaturneV
SaturneV requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@SaturneV SaturneV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! I tested it on my emulator and it works as expected. I'll let you respond to my comments. Maybe the PR description could have been more descriptive about the function added and the test files that were modified for the next time. I'll wait for your answers and quickly approve the PR. Good job!

app/src/main/java/com/android/streetworkapp/model/image/ImageRepositoryFirestore.kt Outdated Show resolved Hide resolved
app/src/main/java/com/android/streetworkapp/model/image/ImageRepositoryFirestore.kt Show resolved Hide resolved
@Alex720p
Copy link
Contributor Author

Great PR! I tested it on my emulator and it works as expected. I'll let you respond to my comments. Maybe the PR description could have been more descriptive about the function added and the test files that were modified for the next time. I'll wait for your answers and quickly approve the PR. Good job!

Shoud have specified for the function but it wasn't a new thing. I brought back the function I had already done in pr #227. I changed it after the review but there was an issue with the updated implementation.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 18, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
82.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

SaturneV
SaturneV approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@SaturneV SaturneV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the responses to my comments and the changes. I approve this PR. Don't forget to accept the issue on SonarCloud. Good job!

@Alex720p Alex720p merged commit ac545d5 into main Dec 18, 2024
3 checks passed
@Alex720p Alex720p deleted the feat/add-image-data-deletion-in-account-deletion branch December 18, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaturneV SaturneV SaturneV approved these changes

Assignees

@Alex720p Alex720p

Labels
Enhancement ✨ New feature or request
Projects
None yet
Milestone
Milestone M3
Development

Successfully merging this pull request may close these issues.

Implement the deletion of all user related image in the existing account deletion
2 participants
@Alex720p @SaturneV