fix(LocationService): fixed currentpark not updating by taking park d… #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irectly form userviewmodel
Simmanz
approved these changes
Dec 19, 2024
…into hotfix/fix-user-parks-not-updating
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
User current park didn't update, enabling people to spam point near a park by reloading the map
Fix: current user now is correctly updated, user won't get point when inside the same park
Changes
LocationService.kt, changed val currentParks to a var and updated currentPark by using the userViewModel directlyYou can test the functionnality by seting your location inside a park and reloading the map