Refactor/Convert string resources #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/com/android/streetworkapp/ui/authentication/SignIn.kt # app/src/main/java/com/android/streetworkapp/ui/map/MapUi.kt # app/src/main/java/com/android/streetworkapp/ui/park/ParkOverview.kt # app/src/main/res/values/strings.xml
# Conflicts: # app/src/main/java/com/android/streetworkapp/ui/train/TrainCoachScreen.kt # app/src/main/res/values/strings.xml
|
|
Because of some issue due to the overall line coverage of the project and the Milstone 3 deadline, the team decided not to merge this Pull Request. I'm closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The aim of this pull request is to refactor the hard coded strings of the application's UI into resource strings and import them from the application's resources in the UI code. This ensures that the app can easily support multiple languages and makes it easier to manage text updates.
Changes
Tests
Please test this refactor by using the app as a user and ensure that the different texts appear as expected.