Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e): add back end2endGeneral #252

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix(e2e): add back end2endGeneral #252

merged 2 commits into from
Dec 20, 2024

Conversation

kzepfl
Copy link
Contributor

@kzepfl kzepfl commented Dec 20, 2024 •
edited
Loading

Remove the @ignore in End2EndGeneral

@kzepfl kzepfl marked this pull request as ready for review December 20, 2024 01:48
@kzepfl kzepfl changed the title fix(e2e): add back all the end2end fix(e2e): add back end2endGeneral Dec 20, 2024
@kzepfl kzepfl self-assigned this Dec 20, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

alvaro1080
alvaro1080 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@alvaro1080 alvaro1080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to re-run the CI and it worked. This version seems reliable on the CI, I approve this Pull Request.

@alvaro1080 alvaro1080 merged commit 6ad668b into main Dec 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaro1080 alvaro1080 alvaro1080 approved these changes

Assignees

@kzepfl kzepfl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kzepfl @alvaro1080