This repository has been archived by the owner on Jan 19, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 219
PR for merge new features of hearthstone #1371
Open
midhatdrops
wants to merge
4
commits into
SwitchbladeBot:dev
Choose a base branch
from
midhatdrops:feature/hearthstone
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doges
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to só esperando a pr #1370 ser merged pra poder dar merge na sua, mas tá LGTM
almeidx
suggested changes
Feb 18, 2022
Comment on lines
+26
to
+33
.setDescriptionFromBlockArray([` -/ CardSet: ${cardSet} | ||
-/ Type: ${type} | ||
-/ Faction: ${faction} | ||
-/ Rarity: ${rarity} | ||
-/ Cost: ${cost} | ||
-/ Atack: ${atack} | ||
-/ Heallth: ${health} points | ||
-/ Text `, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locales?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
te amo, esqueci
`${text}`]) | ||
) | ||
} catch (e) { | ||
channel.send(new SwitchbladeEmbed().setTitle('Card not Found !').setDescription('Search for a valid card Id !')).then(() => channel.stopTyping()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the really delay of those features. Had some hardware & personal problems in the meantime.
Hope that the code it's ok, i had some problems into testing it locally with the bot, so any review and code appointments will be welcomed.