Feature/replace slider #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvanhaevre
approved these changes
Jan 21, 2025
| * @group Hooks | ||
| */ | ||
| export const useCurrentTime = () => { | ||
| const player = useContext(PlayerContext).player; |
There was a problem hiding this comment.
Nit-pick:
Suggested change
| const player = useContext(PlayerContext).player; | |
| const { player } = useContext(PlayerContext); |
There was a problem hiding this comment.
I also replaced this with destructuring assignment in the other hooks.
MattiasBuelens
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop dependency on @react-native-community/slider and replace with @miblanchard/react-native-slider, which is commonly-used a slider implementation in react-native without any native dependencies, available on all platforms (including tvOS).
Also fix the slider crash for live streams passing NaN or Infinite values.