Performance fix for topbar component #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AleksanderEvensen
force-pushed
the
perf/component-topbar
branch
from
c7ca061 to
b0f0963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes
noneChanges:
Replaces the scroll state with a simple boolean state isOver.
This reduces react re-renders from re-rendering on each scroll step, to only re-render once the trigger is reached.
I also took the time to remove the useMediaQuery (why do we have this) hook and replaced it with native CSS.
Screenshots:
React-Scan visualization before
brave_rJOpfXbzDs.mp4
React-Scan visualization after
brave_z6k5ZWa6Om.mp4
Responsive design with CSS media-queries
brave_PLpSwAtMNS.mp4
Pull request checklist
Please check if your PR fulfills the following requirements: