multisave: improve saveMessages UI

- Prevent extra flicker when updating save messages - Show save messages even when livefeed is off
TIM-JYU · Feb 20, 2025 · a96e66c · a96e66c
1 parent f199576
commit a96e66c
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/timApp/modules/fields/js/multisave.ts b/timApp/modules/fields/js/multisave.ts
@@ -92,6 +92,9 @@ const multisaveAll = t.intersection([
             [testOnly]="markup.testOnly"
             [group]="markup.group">
     </tim-sisu-assessment-export>
+    <div *ngIf="saveMessages" class="saveMessages">
+        <div *ngFor="let m of saveMessages">{{m}}</div>
+    </div>
     <div *ngIf="livefeed"> <!-- unsaved fields -->
         <div *ngIf="!allSaved()">
             {{unsavedText}}
@@ -101,9 +104,6 @@ const multisaveAll = t.intersection([
                 </li>
             </ul>
         </div>
-        <div *ngIf="saveMessages" class="saveMessages">
-            <div *ngFor="let m of saveMessages">{{m}}</div>
-        </div>
         <div *ngIf="allSaved()">
             {{allSavedText}}
         </div>
@@ -320,7 +320,7 @@ export class MultisaveComponent
         this.savedFields = 0;
         let savedIndex = 0;
         const fieldsToUpdate: string[] = [];
-        this.saveMessages = [];
+        const saveMessages: string[] = [];
         for (const p of promises) {
             const result = await p;
             if (result.saved) {
@@ -341,12 +341,13 @@ export class MultisaveComponent
                         }
                     }
                 }
-                if (!this.saveMessages.includes(msg)) {
-                    this.saveMessages.push(msg);
+                if (!saveMessages.includes(msg)) {
+                    saveMessages.push(msg);
                 }
             }
             savedIndex++;
         }
+        this.saveMessages = saveMessages;
         if (this.markup.timer && !this.allSaved()) {
             this.setTimer();
         }