Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release prep v1.1.1 #44

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Release prep v1.1.1 #44

merged 2 commits into from
Nov 6, 2024

Conversation

ThomasTNO
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Nov 6, 2024

Sigrid maintainability feedback

⏸️️ Your rating did not change and is still below your objective of 3.5 stars

Sigrid compared your code against the baseline of 2024-11-06.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

Unfortunately, 2 refactoring candidates were introduced or got worse.

Risk System property Location
🔴 Duplication
(Introduced)
WuppieFuzz/src/openapi/examples.rs (lines 556-564)
WuppieFuzz/src/openapi/examples.rs (lines 625-633)
🔴 Duplication
(Introduced)
WuppieFuzz/src/openapi/examples.rs (lines 691-697)
WuppieFuzz/src/openapi/examples.rs (lines 747-753)

📚 Remaining technical debt

22 refactoring candidates didn't get better or worse, but are still present in the code you touched.

Risk System property Location
🔴 Unit Size
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
all_interesting_parameters(Operation,OpenAPI,&,any)
🔴 Unit Size
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
interesting_params_from_type(OpenAPI,Type)
🔴 Unit Size
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
interesting_params_from_schema(OpenAPI,RefOr,&,any)
🟠 Unit Size
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
all_discriminator_variants(OpenAPI,Schema,&,any)
🟠 Unit Size
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
example_from_type(OpenAPI,Type)
🟠 Unit Size
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
example_body_contents(OpenAPI,Operation)
🟠 Unit Size
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
all_interesting_inputs_for_qualified_operation(OpenAPI,QualifiedOperation,&,any)
🟠 Unit Complexity
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
examples.rs
🟠 Unit Complexity
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
interesting_params_from_type(OpenAPI,Type)
🟡 Unit Size
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
example_parameter_value(OpenAPI,ParameterData)
🟡 Unit Size
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
example_parameters(OpenAPI,Operation)
🟡 Unit Size
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
example_from_schema(OpenAPI,Schema)
🟡 Unit Complexity
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
all_interesting_parameters(Operation,OpenAPI,&,any)
🟡 Unit Complexity
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
all_discriminator_variants(OpenAPI,Schema,&,any)
🟡 Unit Complexity
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
interesting_params_from_schema(OpenAPI,RefOr,&,any)
🟡 Unit Interfacing
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
all_interesting_parameters(Operation,OpenAPI,&,any)
🟡 Unit Interfacing
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
all_discriminator_variants(OpenAPI,Schema,&,any)
🟡 Unit Interfacing
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
enforce_length_bounds(str,Option,Option)
🟡 Unit Interfacing
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
example_from_media_type(OpenAPI,openapiv3,any)
🟡 Unit Interfacing
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
all_interesting_inputs_for_qualified_operation(OpenAPI,QualifiedOperation,&,any)
🟡 Unit Interfacing
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
interesting_params_from_schema(OpenAPI,RefOr,&,any)
🟡 Unit Interfacing
(Unchanged)
WuppieFuzz/src/openapi/examples.rs
interesting_params_from_media_type(OpenAPI,openapiv3,any)

Sigrid ratings

System property System on 2024-11-06 Before changes New/changed code
Volume 5.4 N/A N/A
Duplication 3.9 4.3 4.4
Unit Size 2.1 1.0 1.0
Unit Complexity 2.9 1.7 1.7
Unit Interfacing 2.0 1.3 1.3
Module Coupling 3.3 N/A N/A
Component Independence 5.4 N/A N/A
Component Entanglement N/A N/A N/A
Maintainability 3.6 2.1 2.1

View this system in Sigrid


Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.

@ThomasTNO ThomasTNO merged commit f89441b into main Nov 6, 2024
6 checks passed
@ThomasTNO ThomasTNO deleted the release branch November 6, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant