Cargo update + License check #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sigrid maintainability feedback💭️ You did not change any files that are measured by Sigrid |
|
To do: test. To do2: Consider replacing serde_yaml with serde_yml https://github.com/sebastienrousseau/serde_yml |
|
Tested on petstore, still seems to work |
|
@grebnetiew, I would suggest to look later into serde_yml. What do you think? |
I agree, since the https://docs.rs/crate/serde_yml/latest
It seems like a good new issue for someone to look into and decide on and if positive, fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@grebnetiew, did a
cargo updatealso validated the license mentions as they somehow deviated over time..