Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸš€ :: v2.2.3 #394

Merged
merged 1 commit into from
Oct 15, 2024
Merged

πŸš€ :: v2.2.3 #394

merged 1 commit into from
Oct 15, 2024

Conversation

parkuiery
Copy link
Member

@parkuiery parkuiery commented Oct 15, 2024

κ°œμš”

μž‘μ—… λ‚΄μš©

ν•  말

μ—†μŒ

Summary by CodeRabbit

  • μƒˆλ‘œμš΄ κΈ°λŠ₯

    • "μ²΄ν—˜ν˜• ν˜„μž₯μ‹€μŠ΅" κΈ°λŠ₯ μΆ”κ°€
    • "κ²¨μšΈμΈν„΄ μ•Œλ¦Ό" κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •

    • "지원내역이 λ³΅μ‚¬λ˜λŠ” 버그" μˆ˜μ •
    • "μΈμ¦μ½”λ“œ 전솑 버그" μˆ˜μ •
    • "μ§€μ›ν˜„ν™©μ—μ„œ 사진이 μ•ˆλœ¨λŠ” 버그" μˆ˜μ •
  • 버전 μ—…λ°μ΄νŠΈ

    • 버전 λ²ˆν˜Έκ°€ v2.2.2μ—μ„œ v2.2.3으둜 μ—…λ°μ΄νŠΈλ¨

@parkuiery parkuiery added the 배포 앱을 λ°°ν¬ν•©λ‹ˆλ‹€. label Oct 15, 2024
@parkuiery parkuiery self-assigned this Oct 15, 2024
@parkuiery parkuiery requested a review from a team as a code owner October 15, 2024 09:05
Copy link
Contributor

coderabbitai bot commented Oct 15, 2024

Walkthrough

이 ν’€ λ¦¬ν€˜μŠ€νŠΈλŠ” 버전 번호λ₯Ό v2.2.2μ—μ„œ v2.2.3으둜 μ—…λ°μ΄νŠΈν•˜λ©°, 릴리슀 λ…ΈνŠΈμ—μ„œ μ—¬λŸ¬ λ³€κ²½ 사항을 λ°˜μ˜ν•©λ‹ˆλ‹€. "μ‹ κ·œ κΈ°λŠ₯" μ„Ήμ…˜μ—μ„œλŠ” "μ•Œλ¦Ό μ„€μ •" κΈ°λŠ₯이 "μ²΄ν—˜ν˜• ν˜„μž₯μ‹€μŠ΅"κ³Ό "κ²¨μšΈμΈν„΄ μ•Œλ¦Ό"으둜 λŒ€μ²΄λ˜μ—ˆμŠ΅λ‹ˆλ‹€. "κ°œμ„  사항" μ„Ήμ…˜μ€ λ³€κ²½λ˜μ§€ μ•Šμ•˜μœΌλ©°, "버그 μˆ˜μ •" μ„Ήμ…˜μ—μ„œλŠ” μ—¬λŸ¬ μƒˆλ‘œμš΄ λ¬Έμ œμ— λŒ€ν•œ μˆ˜μ • 사항이 μΆ”κ°€λ˜μ—ˆμŠ΅λ‹ˆλ‹€.

Changes

파일 경둜 λ³€κ²½ μš”μ•½
app/src/main/play/release-notes/ko-KR/default.txt 버전 μ—…λ°μ΄νŠΈ(v2.2.2 β†’ v2.2.3), μ‹ κ·œ κΈ°λŠ₯ μΆ”κ°€(μ²΄ν—˜ν˜• ν˜„μž₯μ‹€μŠ΅, κ²¨μšΈμΈν„΄ μ•Œλ¦Ό), κΈ°μ‘΄ κΈ°λŠ₯ 제거(μ•Œλ¦Ό μ„€μ •), 버그 μˆ˜μ • μΆ”κ°€(지원내역 볡사, μΈμ¦μ½”λ“œ 전솑, μ§€μ›ν˜„ν™© 사진 λ―Έν‘œμ‹œ)
buildSrc/src/main/kotlin/ProjectProperties.kt μƒμˆ˜ μ—…λ°μ΄νŠΈ(VERSION_CODE: 16 β†’ 17, VERSION_NAME: "2.2.2" β†’ "2.2.3")

Possibly related PRs

  • πŸš€ :: v2.2.0Β #360: 이 PR은 버전 번호λ₯Ό v2.1.9μ—μ„œ v2.2.0으둜 μ—…λ°μ΄νŠΈν•˜λŠ” λ‚΄μš©μ„ ν¬ν•¨ν•˜κ³  있으며, 메인 PR의 버전 μ—…λ°μ΄νŠΈμ™€ μ§μ ‘μ μœΌλ‘œ 관련이 μžˆμŠ΅λ‹ˆλ‹€.
  • πŸš€ :: v2.2.2Β #364: 이 PR은 v2.2.1μ—μ„œ v2.2.2둜의 버전 μ—…λ°μ΄νŠΈλ₯Ό λ°˜μ˜ν•˜κ³  있으며, 메인 PR의 λ³€κ²½ μ‚¬ν•­μœΌλ‘œ μ΄μ–΄μ§€λŠ” 버전 진행 상황을 λ³΄μ—¬μ€λ‹ˆλ‹€.

Suggested labels

λΉŒλ“œ

Suggested reviewers

  • Tmdhoon2

🐰 λ³€ν™”μ˜ λ°”λžŒμ΄ λΆˆμ–΄μ™€
버전이 μƒˆλ‘œμ›Œμ‘Œμ–΄μš”, 와!
μ•Œλ¦Όμ€ 사라지고,
μƒˆλ‘œμš΄ κΈ°λŠ₯이 피어났죠.
겨울의 인턴, μ²΄ν—˜μ˜ κΈΈ,
λͺ¨λ‘ ν•¨κ»˜ μ¦κ²¨μš”, 기뢄이 μ’‹μ•„μš”! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)
app/src/main/play/release-notes/ko-KR/default.txt (2)

5-6: μƒˆλ‘œμš΄ κΈ°λŠ₯이 μΆ”κ°€λ˜μ—ˆμŠ΅λ‹ˆλ‹€.

μ²΄ν—˜ν˜• ν˜„μž₯μ‹€μŠ΅κ³Ό κ²¨μšΈμΈν„΄ μ•Œλ¦Ό κΈ°λŠ₯이 μΆ”κ°€λœ 것은 μ’‹μŠ΅λ‹ˆλ‹€. ν•˜μ§€λ§Œ 이전 λ²„μ „μ˜ "μ•Œλ¦Ό μ„€μ • κΈ°λŠ₯"이 제거된 μ΄μœ μ— λŒ€ν•΄ μ„€λͺ…이 ν•„μš”ν•  것 κ°™μŠ΅λ‹ˆλ‹€.

각 κΈ°λŠ₯에 λŒ€ν•΄ κ°„λ‹¨ν•œ μ„€λͺ…μ΄λ‚˜ μ‚¬μš© 방법을 μΆ”κ°€ν•˜λŠ” 것이 μ‚¬μš©μžμ—κ²Œ 도움이 될 수 μžˆμŠ΅λ‹ˆλ‹€. 예λ₯Ό λ“€μ–΄:

β€’ μ²΄ν—˜ν˜• ν˜„μž₯μ‹€μŠ΅μ΄ μΆ”κ°€λ˜μ—ˆμ–΄μš”. (κΈ°μ—… νŽ˜μ΄μ§€μ—μ„œ 확인 κ°€λŠ₯)
β€’ κ²¨μšΈμΈν„΄ μ•Œλ¦Όμ„ μΆ”κ°€ν–ˆμ–΄μš”. (μ„€μ • λ©”λ‰΄μ—μ„œ 켜고 끌 수 μžˆμ–΄μš”)

12-14: 버그 μˆ˜μ • 사항이 μΆ”κ°€λ˜μ—ˆμŠ΅λ‹ˆλ‹€.

μƒˆλ‘œμš΄ 버그 μˆ˜μ • 사항듀이 λͺ…ν™•ν•˜κ²Œ κΈ°μˆ λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€. λ‹€λ§Œ, 이전 λ²„μ „μ˜ "λ’€λ‘œκ°€κΈ° 연타 μ‹œ 빈 화면이 λ‚˜νƒ€λ‚˜λŠ” 버그" μˆ˜μ • 사항이 제거된 μ΄μœ μ— λŒ€ν•œ μ„€λͺ…이 ν•„μš”ν•  것 κ°™μŠ΅λ‹ˆλ‹€.

각 버그 μˆ˜μ •μ— λŒ€ν•΄ 쑰금 더 μƒμ„Έν•œ 정보λ₯Ό μ œκ³΅ν•˜λ©΄ 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€. 예λ₯Ό λ“€μ–΄:

β€’ 지원내역이 λ³΅μ‚¬λ˜λŠ” 버그λ₯Ό μˆ˜μ •ν–ˆμ–΄μš”. (쀑볡 지원 방지)
β€’ μΈμ¦μ½”λ“œ 전솑 버그λ₯Ό μˆ˜μ •ν–ˆμ–΄μš”. (이메일 인증 μ‹œ λ°œμƒν•˜λ˜ 문제)
β€’ μ§€μ›ν˜„ν™©μ—μ„œ 사진이 μ•ˆλœ¨λŠ” 버그λ₯Ό μˆ˜μ •ν–ˆμ–΄μš”. (ν”„λ‘œν•„ 이미지 λ‘œλ”© κ°œμ„ )
buildSrc/src/main/kotlin/ProjectProperties.kt (1)

5-6: 버전 μ—…λ°μ΄νŠΈκ°€ μ˜¬λ°”λ₯΄κ²Œ μ΄λ£¨μ–΄μ‘ŒμŠ΅λ‹ˆλ‹€.

VERSION_CODE와 VERSION_NAME이 μ μ ˆν•˜κ²Œ μ—…λ°μ΄νŠΈλ˜μ—ˆμŠ΅λ‹ˆλ‹€. μ΄λŠ” μƒˆ 릴리슀λ₯Ό μΆ”μ ν•˜κ³  Android μ•±μ˜ μ μ ˆν•œ 버전 관리λ₯Ό 보μž₯ν•˜λŠ” 데 ν•„μš”ν•œ λ³€κ²½μ‚¬ν•­μž…λ‹ˆλ‹€.

λ³€κ²½ 둜그(changelog)κ°€ 아직 μ—…λ°μ΄νŠΈλ˜μ§€ μ•Šμ•˜λ‹€λ©΄, 이 μƒˆ 버전에 λŒ€ν•œ λ³€κ²½ 사항을 λ¬Έμ„œν™”ν•˜λŠ” 것이 μ’‹μŠ΅λ‹ˆλ‹€.

πŸ“œ Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

πŸ“₯ Commits

Files that changed from the base of the PR and between 360261f and 9bbb359.

πŸ“’ Files selected for processing (2)
  • app/src/main/play/release-notes/ko-KR/default.txt (1 hunks)
  • buildSrc/src/main/kotlin/ProjectProperties.kt (1 hunks)
🧰 Additional context used
πŸ”‡ Additional comments (1)
app/src/main/play/release-notes/ko-KR/default.txt (1)

1-1: 버전 μ—…λ°μ΄νŠΈκ°€ μ˜¬λ°”λ₯΄κ²Œ λ°˜μ˜λ˜μ—ˆμŠ΅λ‹ˆλ‹€.

PR 제λͺ© 및 λͺ©ν‘œμ™€ μΌμΉ˜ν•˜λŠ” 버전 μ—…λ°μ΄νŠΈκ°€ μ •ν™•ν•˜κ²Œ μ΄λ£¨μ–΄μ‘ŒμŠ΅λ‹ˆλ‹€.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
배포 앱을 λ°°ν¬ν•©λ‹ˆλ‹€.
Projects
Development

Successfully merging this pull request may close these issues.

1 participant