chore(ios): eliminate some warnings

Tencent · May 14, 2024 · 2213315 · 2213315
1 parent 745c7cf
commit 2213315
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 17 deletions.
diff --git a/dom/src/dom/taitank_layout_node.cc b/dom/src/dom/taitank_layout_node.cc
@@ -157,7 +157,7 @@ TAITANK_GET_STYLE_DECL(Direction, TaitankDirection, TaitankDirection::DIRECTION_
   }
 
 static void CheckValueType(footstone::value::HippyValue::Type type) {
-  if (type == footstone::value::HippyValue::Type::kNumber || type == footstone::value::HippyValue::Type::kObject)
+  if (type == footstone::value::HippyValue::Type::kString || type == footstone::value::HippyValue::Type::kObject)
     FOOTSTONE_DLOG(WARNING) << "Taitank Layout Node Value Type Error";
 }
 

diff --git a/modules/footstone/include/footstone/logging.h b/modules/footstone/include/footstone/logging.h
@@ -108,6 +108,7 @@ class LogMessage {
     }
     delegate_ = delegate;
   }
+
   inline static void LogWithFormat(const char * file, int line, const char *format, ...){
     char *log_msg = NULL;
     va_list args;
@@ -124,9 +125,9 @@ class LogMessage {
      <<"[thread:"<<pthread_self()<<"], "<<log_msg<<std::endl;
 
     if (LogMessage::delegate_) {
-      delegate_(s, TDF_LOG_WARNING);
+      delegate_(s, TDF_LOG_INFO);
     } else {
-      default_delegate_(s, TDF_LOG_WARNING);
+      default_delegate_(s, TDF_LOG_INFO);
     }
 
     free(log_msg);

diff --git a/renderer/native/ios/renderer/HippyComponent.h b/renderer/native/ios/renderer/HippyComponent.h
@@ -52,8 +52,8 @@ typedef void (^HippyDirectEventBlock)(NSDictionary *body);
 /// Inset
 /// - Parameters:
 ///   - subview: id
-///   - atIndex: NSInteger
-- (void)insertHippySubview:(id<HippyComponent>)subview atIndex:(NSInteger)atIndex;
+///   - atIndex: NSUInteger
+- (void)insertHippySubview:(id<HippyComponent>)subview atIndex:(NSUInteger)atIndex;
 
 /// Remove
 /// - Parameter subview: id
@@ -62,8 +62,8 @@ typedef void (^HippyDirectEventBlock)(NSDictionary *body);
 /// Move
 /// - Parameters:
 ///   - subview: id
-///   - atIndex: NSInteger
-- (void)moveHippySubview:(id<HippyComponent>)subview toIndex:(NSInteger)atIndex;
+///   - atIndex: NSUInteger
+- (void)moveHippySubview:(id<HippyComponent>)subview toIndex:(NSUInteger)atIndex;
 
 /// Remove from superview
 - (void)removeFromHippySuperview;

diff --git a/renderer/native/ios/renderer/component/listview/HippyNextBaseListView.mm b/renderer/native/ios/renderer/component/listview/HippyNextBaseListView.mm
@@ -163,7 +163,7 @@ - (void)reloadData {
     }
 }
 
-- (void)insertHippySubview:(UIView *)subview atIndex:(NSInteger)atIndex {
+- (void)insertHippySubview:(UIView *)subview atIndex:(NSUInteger)atIndex {
     if ([subview isKindOfClass:[HippyHeaderRefresh class]]) {
         if (_headerRefreshView) {
             [_headerRefreshView unsetFromScrollView];

diff --git a/renderer/native/ios/renderer/component/view/HippyShadowView.mm b/renderer/native/ios/renderer/component/view/HippyShadowView.mm
@@ -177,7 +177,7 @@ - (UIView *)createView:(HippyViewCreationBlock)creationBlock insertChildren:(Hip
     return container;
 }
 
-- (void)insertHippySubview:(HippyShadowView *)subview atIndex:(NSInteger)atIndex {
+- (void)insertHippySubview:(HippyShadowView *)subview atIndex:(NSUInteger)atIndex {
     if (atIndex <= [_objectSubviews count]) {
         [_objectSubviews insertObject:subview atIndex:atIndex];
     }
@@ -190,7 +190,7 @@ - (void)insertHippySubview:(HippyShadowView *)subview atIndex:(NSInteger)atIndex
     [self dirtyPropagation:NativeRenderUpdateLifecycleLayoutDirtied];
 }
 
-- (void)moveHippySubview:(id<HippyComponent>)subview toIndex:(NSInteger)atIndex {
+- (void)moveHippySubview:(id<HippyComponent>)subview toIndex:(NSUInteger)atIndex {
     if ([_objectSubviews containsObject:subview]) {
         [_objectSubviews removeObject:subview];
     }

diff --git a/renderer/native/ios/renderer/component/view/UIView+Hippy.mm b/renderer/native/ios/renderer/component/view/UIView+Hippy.mm
@@ -158,7 +158,7 @@ - (void)setParent:(id<HippyComponent>)parent {
     }
 }
 
-- (void)insertHippySubview:(UIView *)subview atIndex:(NSInteger)atIndex {
+- (void)insertHippySubview:(UIView *)subview atIndex:(NSUInteger)atIndex {
     // We access the associated object directly here in case someone overrides
     // the `subcomponents` getter method and returns an immutable array.
     if (nil == subview) {
@@ -172,14 +172,13 @@ - (void)insertHippySubview:(UIView *)subview atIndex:(NSInteger)atIndex {
 
     if (atIndex <= [subviews count]) {
         [subviews insertObject:subview atIndex:atIndex];
-    }
-    else {
+    } else {
         [subviews addObject:subview];
     }
     subview.parent = self;
 }
 
-- (void)moveHippySubview:(UIView *)subview toIndex:(NSInteger)atIndex {
+- (void)moveHippySubview:(UIView *)subview toIndex:(NSUInteger)atIndex {
     if (nil == subview) {
         return;
     }

diff --git a/renderer/native/ios/renderer/component/viewPager/HippyViewPager.mm b/renderer/native/ios/renderer/component/viewPager/HippyViewPager.mm
@@ -85,7 +85,7 @@ - (void)didMoveToSuperview {
 
 #pragma mark native render native methods
 
-- (void)insertHippySubview:(UIView *)view atIndex:(NSInteger)atIndex {
+- (void)insertHippySubview:(UIView *)view atIndex:(NSUInteger)atIndex {
     if (atIndex > self.viewPagerItems.count) {
         HippyLogWarn(@"Error In HippyViewPager: addSubview —— out of bound of array");
         return;

diff --git a/renderer/native/ios/renderer/component/waterfalllist/HippyShadowListView.mm b/renderer/native/ios/renderer/component/waterfalllist/HippyShadowListView.mm
@@ -150,7 +150,7 @@ - (WaterfallItemChangeContext *)itemChangeContext {
     return _itemChangeContext;
 }
 
-- (void)insertHippySubview:(HippyShadowView *)subview atIndex:(NSInteger)atIndex {
+- (void)insertHippySubview:(HippyShadowView *)subview atIndex:(NSUInteger)atIndex {
     [super insertHippySubview:subview atIndex:atIndex];
     if ([subview isKindOfClass:[HippyShadowWaterfallItem class]]) {
         HippyShadowWaterfallItem *objectItem = (HippyShadowWaterfallItem *)subview;
@@ -168,7 +168,7 @@ - (void)removeHippySubview:(HippyShadowView *)subview {
     [_itemChangeContext appendDeletedItem:subview];
 }
 
-- (void)moveHippySubview:(id<HippyComponent>)subview toIndex:(NSInteger)atIndex {
+- (void)moveHippySubview:(id<HippyComponent>)subview toIndex:(NSUInteger)atIndex {
     [super moveHippySubview:subview toIndex:atIndex];
     [_itemChangeContext appendMovedItem:subview];
 }