fix(ios): avoid startup crash when script load error

Tencent · Sep 13, 2024 · 7197030 · 7197030
1 parent 62d777e
commit 7197030
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/framework/ios/base/bridge/HippyBridge.mm b/framework/ios/base/bridge/HippyBridge.mm
@@ -589,7 +589,8 @@ - (void)beginLoadingBundle:(NSURL *)bundleURL
         if (!strongSelf || !strongSelf.valid || !script) {
             NSString *errMsg = [NSString stringWithFormat:@"Bundle Execution Operation Fail! valid:%d, script:%@",
                                 strongSelf.valid, script];
-            completion(nil, HippyErrorWithMessage(errMsg));
+            HippyLogError(@"%@", errMsg);
+            completion(bundleURL, HippyErrorWithMessage(errMsg));
             strongSelf.lastExecuteOperation = nil;
             return;
         }

diff --git a/renderer/native/ios/renderer/HippyRootView.mm b/renderer/native/ios/renderer/HippyRootView.mm
@@ -185,7 +185,7 @@ - (instancetype)initWithBridge:(HippyBridge *)bridge
                     }
 
                     // 抛出业务包(BusinessBundle aka SecondaryBundle)加载完成通知，for hippy2兼容
-                    NSMutableDictionary *userInfo = @{ kHippyNotiBundleUrlKey: url,
+                    NSMutableDictionary *userInfo = @{ kHippyNotiBundleUrlKey: url ?: @"",
                                                        kHippyNotiBridgeKey: strongSelf.bridge }.mutableCopy;
                     if (error) { [userInfo setObject:error forKey:kHippyNotiErrorKey]; }
                     HIPPY_IGNORE_WARNING_BEGIN(-Wdeprecated)