Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): remove the invalid log message #3749

Merged
merged 1 commit into from
Feb 21, 2024
Merged

fix(ios): remove the invalid log message #3749

merged 1 commit into from
Feb 21, 2024

Conversation

xuqingkuang
Copy link
Contributor

Remove the unncessary message from log

@github-actions github-actions bot added framework: ios size: xs Denotes a PR that changes 0-9 lines labels Feb 5, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Feb 5, 2024

Hi, @xuqingkuang. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Feb 5, 2024

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@wwwcg wwwcg force-pushed the xuqingkuang/remove-invalid-log-message branch from 16e569e to f8f541e Compare February 21, 2024 06:29
wwwcg
wwwcg approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@wwwcg wwwcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hippy-service Hippy Service
Copy link

hippy-service bot commented Feb 21, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Feb 21, 2024
@hippy-actions hippy-actions bot enabled auto-merge (rebase) February 21, 2024 06:31
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Feb 21, 2024
@hippy-actions hippy-actions bot merged commit 0a0d88d into Tencent:master Feb 21, 2024
31 of 32 checks passed
@xuqingkuang xuqingkuang deleted the xuqingkuang/remove-invalid-log-message branch July 3, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwwcg wwwcg wwwcg approved these changes

@ruifanyuan ruifanyuan Awaiting requested review from ruifanyuan ruifanyuan is a code owner

Assignees
No one assigned
Labels
framework: ios size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuqingkuang @wwwcg