Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "Settings" option in integration screen #549

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iTrooz
Copy link
Contributor

@iTrooz iTrooz commented Dec 12, 2022

#530 but in a different branch

@TheAssassin
Copy link
Owner

I just had a glance. Seems like a good idea. What I don't like is that we just close the dialog. I understand that we cannot just open the settings on top because we'd have to reload the current dialog's settings then (and also, the settings application is a standalone tool, but then again that could be fixed).

Let's target the upcoming release, but postpone merging to after "I can package this app as .deb and .rpm again". (That is making progress, by the way.)

@TheAssassin TheAssassin added this to the version-3.0 milestone Jul 10, 2023
@iTrooz
Copy link
Contributor Author

iTrooz commented Jul 12, 2023

Okay, I'll wait until that is done then

thanks for responding !

@TheAssassin
Copy link
Owner

For the record, version 3.0.0 is on track and the packaging issues have been resolved, so work could be picked up here again.

@iTrooz
Copy link
Contributor Author

iTrooz commented Feb 13, 2025

Sure ! Any idea how to solve the problem you pointed out ?
IMO it's a non problem, because the integration dialog doesn't use the settings anyway (?)

@TheAssassin
Copy link
Owner

IMO it's a non problem, because the integration dialog doesn't use the settings anyway (?)

Well, there is the main integration directory which can be configured in the settings...

@iTrooz
Copy link
Contributor Author

iTrooz commented Feb 13, 2025

Ok, fair.
I am not familiar with AppImageLauncher, but I assume the settings are stored in some kind of file ? How about we:

  • launch a Qt subprocess with the settings program
  • make Qt disable the integration window
  • connect to the subprocess finished signal to re-read the settings file and re-enable the window

@TheAssassin
Copy link
Owner

Seems a bit overkill. I'll think about an easier solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants