Improved sweep command

TheBastionBot · Apr 4, 2017 · 56078c6 · 56078c6
1 parent 36fe105
commit 56078c6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/changes.json b/changes.json
@@ -1,9 +1,10 @@
 {
-  "date": "April 3, 2017",
+  "date": "April 4, 2017",
   "updated": [
     "Some improvements to todo module",
     "Some fixes to pagination",
-    "Some improvements"
+    "Some improvements",
+    "Improved `sweep` command"
   ],
   "added": [
     "`addSelfAssignableRoles` command",

diff --git a/modules/queries/sweep.js b/modules/queries/sweep.js
@@ -20,22 +20,20 @@
  */
 
 exports.run = (Bastion, message, args) => {
-  let members = message.channel.members.filter(m => !m.user.bot).map(m => m.user.id);
-  let sweepedUserId = members[Math.floor(Math.random()*members.length)];
-  let sweepedUser = message.channel.members.get(sweepedUserId).user;
+  let sweepedUser = message.channel.members.filter(m => !m.user.bot).random();
 
   message.channel.sendMessage('', {embed: {
     color: 6651610,
     title: 'Sweeped user',
     fields: [
       {
         name: 'User',
-        value: `**${sweepedUser.username}**#${sweepedUser.discriminator}`,
+        value: `**${sweepedUser.user.username}**#${sweepedUser.user.discriminator}`,
         inline: true
       },
       {
         name: 'ID',
-        value: sweepedUserId,
+        value: sweepedUser.id,
         inline: true
       }
     ]
@@ -50,7 +48,7 @@ exports.config = {
 
 exports.help = {
   name: 'sweep',
-  description: 'Shows a random user from the server.',
+  description: 'Shows a random user from the channel.',
   permission: '',
   usage: 'sweep',
   example: []