doc: Add description for new aws template param (TLSCertificateSecretARN) #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlasebian
requested review from
KrishnaIyer,
johanstokking and
nejraselimovic
as code owners
KrishnaIyer
reviewed
Oct 9, 2024
There was a problem hiding this comment.
This change describes what we've added. Let's also describe why.
In the prerequisites section, please add an optional item for custom TLS certificates. Let's highlight the use of the secret here and not the params.
In the future, we should deprecate the TLS*** parameters since an AWS Secret was always the right way to do this.
vlasebian
force-pushed
the
doc/add-new-param-aws-template
branch
from
5c7053d to
22f3557
Compare
vlasebian
force-pushed
the
doc/add-new-param-aws-template
branch
from
22f3557 to
5eec840
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add description for new param added in this PR for the AWS deployment template.
Notes for Reviewers
None
Checklist
make server, posted screenshots, verified external links. Test withHUGO_PARAMS_SEARCH_ENABLED=trueif style changes will affect the search bar.new-in-versionshortcode, according to the guidelines in CONTRIBUTING.