fix: does not throw an error if KeyboardEvent has no key

ThibaudAV · Oct 6, 2020 · 1e3b7d0 · 1e3b7d0
1 parent a8a029e
commit 1e3b7d0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/projects/ngx-raptorize/src/lib/konamiCode.directive.spec.ts b/projects/ngx-raptorize/src/lib/konamiCode.directive.spec.ts
@@ -36,6 +36,10 @@ describe('KonamiCodeDirective', () => {
     fixture.detectChanges();
   });
 
+  it('should do nothing if the event has no key', () => {
+    document.dispatchEvent(new Event('keydown'));
+  });
+
   describe('when proper sequence is entered', () => {
     it('should trigger konami event', () => {
       document.dispatchEvent(upArrow);

diff --git a/projects/ngx-raptorize/src/lib/konamiCode.directive.ts b/projects/ngx-raptorize/src/lib/konamiCode.directive.ts
@@ -24,6 +24,9 @@ export class KonamiCodeDirective {
 
   @HostListener('document:keydown', ['$event'])
   handleKeyboardEvent(event: KeyboardEvent) {
+    if (!event.key) {
+      return;
+    }
     const key = event.key.toString();
 
     if (key) {