Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Notification & API Integrations #190

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rcohngru-ab-carval
Copy link
Contributor

  • adds support for varying types of api and notification integrations
  • updates the docs to be reflective of the above changes

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 48 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
titan/data_provider.py 7.40% 25 Missing ⚠️
titan/resources/api_integration.py 77.02% 17 Missing ⚠️
...s/integration/data_provider/test_fetch_resource.py 0.00% 6 Missing ⚠️
Files with missing lines Coverage Δ
titan/resources/__init__.py 100.00% <100.00%> (ø)
titan/resources/notification_integration.py 71.51% <ø> (-4.25%) ⬇️
...s/integration/data_provider/test_fetch_resource.py 14.03% <0.00%> (-82.52%) ⬇️
titan/resources/api_integration.py 82.17% <77.02%> (-17.83%) ⬇️
titan/data_provider.py 12.24% <7.40%> (-70.54%) ⬇️

... and 41 files with indirect coverage changes

@rcohngru-ab-carval rcohngru-ab-carval changed the title Fix: Notification & API Integrations [FEAT]: Notification & API Integrations Jan 23, 2025
@rcohngru-ab-carval rcohngru-ab-carval had a problem deploying to snowflake-aws-business-critical January 25, 2025 01:21 — with GitHub Actions Failure
@rcohngru-ab-carval
Copy link
Contributor Author

Hey @teej is there anything I can do to help resolve these failing integration tests? It looks like the error for all of them is "User is empty", which I'm guessing has to do with configurations. Let me know!

@teej
Copy link
Collaborator

teej commented Jan 28, 2025

It has something to do with the way I have credentials set up for the integration tests. I can merge this PR later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants