Advantage kit pivot #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonElia
approved these changes
Oct 5, 2024
Ishan1522
reviewed
Oct 5, 2024
Ishan1522
reviewed
Oct 5, 2024
Ishan1522
reviewed
Oct 5, 2024
Ishan1522
reviewed
Oct 5, 2024
| io.setFollowerVoltage(volts); | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
add a method at some point that sets pivot (w/ pid) based on range from speaker
There was a problem hiding this comment.
doesn't all of that stuff go in PivotIO? or do I need to have it here too?
Ishan1522
reviewed
Oct 5, 2024
Ishan1522
reviewed
Oct 5, 2024
Ishan1522
reviewed
Oct 5, 2024
Ishan1522
reviewed
Oct 5, 2024
Ishan1522
reviewed
Oct 5, 2024
Ishan1522
reviewed
Oct 5, 2024
Ishan1522
reviewed
Oct 5, 2024
removed sysId bcuz we dont use it sim actually logs inputs now conversion stuff for logging units styled and cleaned up code w/ docstrings and spacing added constants for pivot mass and length
|
looks like the Check Format Java failed because of something in the swerve subsystem - do I have to address that? |
|
It's failing due to the spacing in your constants and your pivot files. you just have to run ./gradlew spotlessApply to fix it. |
|
u need to pull from main for spotless to work |
Ishan1522
reviewed
Oct 7, 2024
|
i didn't mean to close it |
…n-robot-code-2024 into Advantage-Kit-Pivot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that everything should be correct - not 100% sure though(specifically tuning for replay and sim modes in pivot.java)