feat: add CLI flag to disable loading of gainmaps #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom94
force-pushed
the
optional-gainmap
branch
3 times, most recently
from
67289d0 to
1b39dee
Compare
Also overhauls loading of images: instead of checking for format compatibility in a separate step from loading, both are now handled in the same (ImageLoader::load) function. A special type of exception is instead thrown if the format is deemed to be unsupported, in which case the next loader in will be tried in order. This doesn't just simplify a whole bunch of logic but also avoids loading image data into memory twice when loading Ultra HDR JPEG images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also overhauls loading of images: instead of checking for format compatibility in a separate step from loading, both are now handled in the same (ImageLoader::load) function. A special type of exception is instead thrown if the format is deemed to be unsupported, in which case the next loader in will be tried in order. This doesn't just simplify a whole bunch of logic but also avoids loading image data into memory twice when loading Ultra HDR JPEG images.