Add --longest option to spot longest files

TomasVotruba · Jul 12, 2024 · 5738d5a · 5738d5a
1 parent 9922322
commit 5738d5a
Show file tree

Hide file tree

Showing 5 changed files with 43 additions and 5 deletions.
diff --git a/src/Console/Command/MeasureCommand.php b/src/Console/Command/MeasureCommand.php
@@ -44,6 +44,7 @@ protected function configure(): void
         $this->addOption('json', null, InputOption::VALUE_NONE, 'Output in JSON format');
         $this->addOption('short', null, InputOption::VALUE_NONE, 'Print short metrics only');
         $this->addOption('allow-vendor', null, InputOption::VALUE_NONE, 'Allow /vendor directory to be scanned');
+        $this->addOption('longest', null, InputOption::VALUE_NONE, 'Show top 10 longest files');
     }
 
     /**
@@ -56,6 +57,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $isJson = (bool) $input->getOption('json');
         $isShort = (bool) $input->getOption('short');
         $allowVendor = (bool) $input->getOption('allow-vendor');
+        $showLongestFiles = (bool) $input->getOption('longest');
 
         $filePaths = $this->phpFilesFinder->findInDirectories($paths, $excludes, $allowVendor);
         if ($filePaths === []) {
@@ -68,9 +70,9 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         // print results
         if ($isJson) {
-            $this->jsonOutputFormatter->printMeasurement($measurement, $isShort);
+            $this->jsonOutputFormatter->printMeasurement($measurement, $isShort, $showLongestFiles);
         } else {
-            $this->textOutputFormatter->printMeasurement($measurement, $isShort);
+            $this->textOutputFormatter->printMeasurement($measurement, $isShort, $showLongestFiles);
         }
 
         return Command::SUCCESS;

diff --git a/src/Console/OutputFormatter/JsonOutputFormatter.php b/src/Console/OutputFormatter/JsonOutputFormatter.php
@@ -10,7 +10,7 @@
 
 final class JsonOutputFormatter implements OutputFormatterInterface
 {
-    public function printMeasurement(Measurements $measurements, bool $isShort): void
+    public function printMeasurement(Measurements $measurements, bool $isShort, bool $showLongestFiles): void
     {
         $arrayData = [
             'filesystem' => [
@@ -57,6 +57,10 @@ public function printMeasurement(Measurements $measurements, bool $isShort): voi
             ];
         }
 
+        if ($showLongestFiles) {
+            $arrayData['longest_files'] = $measurements->getLongestFiles();
+        }
+
         $jsonString = json_encode($arrayData, JSON_PRETTY_PRINT);
         Assert::string($jsonString);
 

diff --git a/src/Console/OutputFormatter/TextOutputFormatter.php b/src/Console/OutputFormatter/TextOutputFormatter.php
@@ -21,7 +21,7 @@ public function __construct(
     ) {
     }
 
-    public function printMeasurement(Measurements $measurements, bool $isShort): void
+    public function printMeasurement(Measurements $measurements, bool $isShort, bool $showLongestFiles): void
     {
         $this->symfonyStyle->newLine();
 
@@ -37,6 +37,17 @@ public function printMeasurement(Measurements $measurements, bool $isShort): voi
         $this->printStructure($measurements);
         $this->printMethods($measurements);
 
+        if ($showLongestFiles) {
+            $rows = [];
+            foreach ($measurements->getLongestFiles() as $filePath => $linesCount) {
+                $rows[] = [$filePath, $linesCount];
+            }
+
+            $tableRows = $this->formatRows($rows);
+            $tableView = new TableView('Longest files', 'Line count', $tableRows);
+            $this->viewRenderer->renderTableView($tableView);
+        }
+
         $this->symfonyStyle->newLine();
     }
 

diff --git a/src/Contract/OutputFormatterInterface.php b/src/Contract/OutputFormatterInterface.php
@@ -8,5 +8,5 @@
 
 interface OutputFormatterInterface
 {
-    public function printMeasurement(Measurements $measurements, bool $isShort): void;
+    public function printMeasurement(Measurements $measurements, bool $isShort, bool $showLongestFiles): void;
 }
diff --git a/src/Measurements.php b/src/Measurements.php
@@ -48,10 +48,18 @@ final class Measurements
      */
     private array $namespaceNames = [];
 
+    /**
+     * @var array<string, int>
+     */
+    private array $filesToSize = [];
+
     public function addFile(string $filename): void
     {
         $this->directoryNames[] = dirname($filename);
 
+        $relativeFilePath = str_replace(getcwd() . '/', '', $filename);
+        $this->filesToSize[$relativeFilePath] = substr_count(file_get_contents($filename), "\n") + 1;
+
         ++$this->fileCount;
     }
 
@@ -134,6 +142,7 @@ public function getDirectoryCount(): int
     {
         $uniqueDirectoryNames = array_unique($this->directoryNames);
         return count($uniqueDirectoryNames) - 1;
+
     }
 
     public function getFileCount(): int
@@ -290,6 +299,18 @@ public function getEnumCount(): int
         return $this->enumCount;
     }
 
+    /**
+     * @return array<string, int>
+     */
+    public function getLongestFiles(): array
+    {
+        // longest files first
+        arsort($this->filesToSize);
+
+        // get top 10
+        return array_slice($this->filesToSize, 0, 10);
+    }
+
     private function relative(int $partialNumber, int $totalNumber): float
     {
         $relative = ($partialNumber / $totalNumber) * 100;