Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only update scales if all actions work correctly #8

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix: only update scales if all actions work correctly #8

merged 1 commit into from
Jan 31, 2024

Conversation

alan890104
Copy link
Contributor

No description provided.

@alan890104 alan890104 changed the title fix: only update scales if all actions successfully fix: only update scales if all actions work correctly Jan 29, 2024
@ipromise2324 ipromise2324 merged commit 7e7a475 into dev Jan 31, 2024
1 check passed
ipromise2324
ipromise2324 reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@ipromise2324 ipromise2324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! By modifying the variables inside the contract only at the end, it solved the issue of operation failure while still altering the contract's variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipromise2324 ipromise2324 ipromise2324 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alan890104 @ipromise2324