Add a new Module for the Liquidity Pool project(s) #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This liquidity pool project is so far just a plain copy of the musicdao project with the name replaced with Liquidity Pool. We will further build on this module in the future.
This initial setup is not fully functional yet but contains the building blocks of performing a trade and joining a pool as a liquidity provider.
These functionalities should now both be functional.
We found a few small bugs that needed fixing. We also did some cleaning up of the code and layouts.
By group 1: Emiel Bos, Daan de Heij, and Thijs Versfelt
Some magic strings got extracted to a constant in the gradle build config.
xoriole
changed the title
This was referenced Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken PR #56