Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G5.125 support d11 #126

Merged
merged 8 commits into from
Nov 22, 2024
Merged

G5.125 support d11 #126

merged 8 commits into from
Nov 22, 2024

Conversation

laceysanderson
Copy link
Member

@laceysanderson laceysanderson commented Nov 21, 2024

Issue #125

Motivation

We need to update the automated testing grid to test these versions and fix any issues that crop up. We also need to add these versions to our automated docker builds. It may be worth separating our current image into a base and module just like I did in Tripal core for faster build times and easier testing.

What does this PR do?

  • Update GitHub workflows to include Drupal 10.5, 11.0, + 11.1 and remove 10.2.
  • Fix any issues that the automated tests reveal.
  • Update devcontainer to run on Drupal 11.1 and to use the new base image.
  • Update README testing grid and associated workflows.

Testing

Automated Testing

This PR does not add any additional automated tests. Instead it simply expands the versions these tests are ran on.

Manual Testing

  1. Checkout this branch locally, open it in VSCode and "Reopen in Container".
  2. Confirm that devcontainer builds properly (i.e. no screaming error 😉) and open the webpage in the browser to confirm versions. Note it is now building Drupal 11.1
Screenshot 2024-11-21 at 4 10 40 PM
  1. Also check the README on this branch by going to the following link and confirm the testing grid renders properly with it's badges.
    https://github.com/TripalCultivate/TripalCultivate-Phenotypes/tree/g5.125-supportD11?tab=readme-ov-file#automated-testing
Screenshot 2024-11-21 at 4 49 52 PM
  1. Configure the module for use and confirm no errors pop-up while you do so:
    a) Create an organism
    b) Go to configure ontologies (admin/tripal/extension/tripal-cultivate/phenotypes/ontology) and configure the organism
    c) Go to the trait importer and ensure it looks right

@laceysanderson laceysanderson linked an issue Nov 21, 2024 that may be closed by this pull request
carolyncaron
carolyncaron previously approved these changes Nov 21, 2024
Copy link
Contributor

@carolyncaron carolyncaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README looks good, the site reports being on Drupal 11.1, the Traits Importer looks good to me after creating an organism and configuring.

Assuming that tests pass (and my suggestion gets applied 😁) this PR looks ready to merge 👍

README.md Outdated Show resolved Hide resolved
@laceysanderson laceysanderson marked this pull request as ready for review November 22, 2024 15:21
Co-authored-by: Carolyn T Caron <carolyn.caron@usask.ca>
@laceysanderson laceysanderson merged commit 3b884bd into 4.x Nov 22, 2024
32 checks passed
@laceysanderson laceysanderson deleted the g5.125-supportD11 branch November 22, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

G5.125 Support Drupal 10.5, 11.0 + 11.1
2 participants