support static ip #158

Smithx10 · 2021-03-29T14:34:25Z

Addresses #157

bahamat

Need to fix make check, but otherwise this looks good.

teutat3s · 2021-09-01T11:55:50Z

make check is looking green here. If I understand the file https://github.com/joyent/sdc-docker/blob/master/tools/check-docs.sh correctly, it only checks in the docs/ directory, where no changes were made - or did you mean missing docs?

bahamat · 2021-09-01T16:13:37Z

@teutat3s It's a bit confusing, because the target is check::. The double colon means there are multiple targets with the same name and running make check executes all of them. The other checks are defined in deps/eng/tools/mk/Makefile.targ (which is a submodule).

Specifically, the following sub-checks fail:

check-jsl
check-jsstyle
check-copyright

teutat3s · 2021-09-01T16:36:59Z

@bahamat thanks for clarifying, I'll see what I can do to contribute and fix these failing sub-checks.

teutat3s · 2021-11-16T13:04:33Z

@Smithx10 I tried addressing the make check errors in Smithx10#1
Feedback welcome!

Static addresses: fix make check

teutat3s · 2021-11-19T12:31:09Z

@bahamat make check should be all green now.

EDIT: probably this is required before merging this?
TritonDataCenter/node-triton-tags#5

bahamat · 2021-11-19T16:35:10Z

Ok, this is looking good so far.

I'd like to see at least some integration tests created, and the test run to see the results.

The following tests should be created:

create instance with IP on owned network gets created properly
create instance with multiple IPs on different owned networks
create instance with multiple IPs on same owned network
create instance with IP on non-owned network gets rejected properly
create instance with IP on owned network and IP on non-owned network gets rejected properly

In order to do this, you'll need an image built that includes TritonDataCenter/node-triton-tags#5. The easiest way to do that is to change package.json in this commit to point triton-tags at https://github.com/Smithx10/node-triton-tags#e4c543ffad2e36e180e7446b5527223cb413c39f and our Jenkins will build an image for you and put it in the experimental channel.

teutat3s · 2021-12-14T18:41:09Z

@bahamat should the image already be built or does it take a bit?

[root@headnode (dc-1) ~]# sdcadm avail -C experimental docker
SERVICE  IMAGE                                 VERSION
docker   5f7af963-c87c-432a-b04f-be2784298487  docker@PR-158-20211119T162303Z-gf1a5a92

bahamat · 2021-12-14T18:58:25Z

@teutat3s I think automatic builds only happen when they come from joyent owned repos (otherwise it could be dangerous). I've kicked off a build so you should see it in a few minutes.

teutat3s · 2021-12-15T15:30:43Z

Something seems to be broken in that image:

EDIT: Maybe a sync with joyent/node-triton-tags's master branch is necessary?

Click to expand

[ Dec 15 15:17:35 Enabled. ]
[ Dec 15 15:17:35 Rereading configuration. ]
[ Dec 15 15:17:41 Executing start method ("/opt/smartdc/docker/smf/method/docker start"). ]
+ . /lib/svc/share/smf_include.sh
++ SMF_EXIT_OK=0
++ SMF_EXIT_NODAEMON=94
++ SMF_EXIT_ERR_FATAL=95
++ SMF_EXIT_ERR_CONFIG=96
++ SMF_EXIT_MON_DEGRADE=97
++ SMF_EXIT_MON_OFFLINE=98
++ SMF_EXIT_ERR_NOSMF=99
++ SMF_EXIT_ERR_PERM=100
+ PATH=/usr/sbin:/usr/bin
+ export PATH
+ case "$1" in
+ exit 0
+ /usr/bin/ctrun -l child -o noorphan /opt/smartdc/docker/build/node/bin/node --abort_on_uncaught_exception /opt/smartdc/docker/lib/docker.js
[ Dec 15 15:17:41 Method "start" exited with status 0. ]
[2021-12-15T15:17:43.234Z]  INFO: docker/57712 on 88e4c263-658f-4b02-a698-d5637a256f81: Loading config from "/opt/smartdc/docker/etc/config.json"
Uncaught Error: Cannot find module './cmon-groups-tag'

FROM
Function.Module._load (module.js:478:5)
Module.require (module.js:504:17)
require (internal/module.js:20:19)
Object.<anonymous> (/opt/smartdc/docker/node_modules/triton-tags/lib/index.js:35:21)
Module._compile (module.js:577:32)
Object.Module._extensions..js (module.js:586:34)
Module.load (module.js:494:32)
tryModuleLoad (module.js:453:12)
Function.Module._load (module.js:445:3)
Module.require (module.js:504:17)
require (internal/module.js:20:19)
Object.<anonymous> (/opt/smartdc/docker/lib/backends/sdc/utils.js:16:19)
Module._compile (module.js:577:32)
Object.Module._extensions..js (module.js:586:34)
Module.load (module.js:494:32)
tryModuleLoad (module.js:453:12)
Function.Module._load (module.js:445:3)
Module.require (module.js:504:17)
require (internal/module.js:20:19)
Object.<anonymous> (/opt/smartdc/docker/lib/backends/sdc/images.js:57:13)
Module._compile (module.js:577:32)
Object.Module._extensions..js (module.js:586:34)
Module.load (module.js:494:32)
tryModuleLoad (module.js:453:12)
Function.Module._load (module.js:445:3)
Module.require (module.js:504:17)
require (internal/module.js:20:19)
Object.<anonymous> (/opt/smartdc/docker/lib/backends/sdc/build.js:28:14)
Module._compile (module.js:577:32)
Object.Module._extensions..js (module.js:586:34)
Module.load (module.js:494:32)
tryModuleLoad (module.js:453:12)
Function.Module._load (module.js:445:3)
Module.require (module.js:504:17)
require (internal/module.js:20:19)
Object.<anonymous> (/opt/smartdc/docker/lib/backends/sdc/index.js:17:13)
Module._compile (module.js:577:32)
Object.Module._extensions..js (module.js:586:34)
Module.load (module.js:494:32)
tryModuleLoad (module.js:453:12)
Function.Module._load (module.js:445:3)
Module.require (module.js:504:17)
require (internal/module.js:20:19)
new App (/opt/smartdc/docker/lib/docker.js:75:19)
main (/opt/smartdc/docker/lib/docker.js:649:15)
Object.<anonymous> (/opt/smartdc/docker/lib/docker.js:653:1)
Module._compile (module.js:577:32)
Object.Module._extensions..js (module.js:586:10)
Module.load (module.js:494:32)
tryModuleLoad (module.js:453:12)
Function.Module._load (module.js:445:3)
Module.runMain (module.js:611:10)
run (bootstrap_node.js:394:7)
startup (bootstrap_node.js:160:9)
bootstrap_node.js:507:3
[ Dec 15 15:17:44 Stopping because all processes in service exited. ]
[ Dec 15 15:17:44 Executing stop method (:kill). ]

teutat3s · 2021-12-15T15:53:15Z

@bahamat would you be so kind and trigger another build? Or do you have an idea what else could have gone wrong with that image?

bahamat · 2021-12-15T18:01:22Z

Build started. Should be ready in about 5 minutes from now.

teutat3s · 2021-12-16T08:52:32Z

Same result. Could there be a step missing in the build process? It seems the .pegjs files are not rendered?

[root@88e4c263-658f-4b02-a698-d5637a256f81 (dc-1:docker0) ~]# ls /opt/smartdc/docker/node_modules/triton-tags/lib
cmon-groups-tag.pegjs  cns-svc-tag.pegjs  index.js

EDIT:
It seems those files are only rendered when cutting a new release, is there a workaround to get those into the experimental image?
https://github.com/joyent/node-triton-tags/blob/6d78099450aae993bededf03bf71f085ac700d55/Makefile#L33-L41

Bruce Smith added 2 commits March 29, 2021 10:31

support static ip

0dd6ee3

IPAM Config only exists when IP is given

353e197

bahamat requested changes May 21, 2021

View reviewed changes

teutat3s added 2 commits November 16, 2021 13:03

Fix make check

73bed19

Merge branch 'master' into static_addresses

703c276

Merge pull request #1 from greenbaum/static_addresses

f1a5a92

Static addresses: fix make check

Use changes from TritonDataCenter/node-triton-tags#5

5a0a6eb

teutat3s force-pushed the static_addresses branch from a04acd3 to 5a0a6eb Compare December 15, 2021 15:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support static ip #158

support static ip #158

Smithx10 commented Mar 29, 2021 •

edited

Loading

bahamat left a comment

teutat3s commented Sep 1, 2021

bahamat commented Sep 1, 2021

teutat3s commented Sep 1, 2021

teutat3s commented Nov 16, 2021

teutat3s commented Nov 19, 2021 •

edited

Loading

bahamat commented Nov 19, 2021

teutat3s commented Dec 14, 2021

bahamat commented Dec 14, 2021

teutat3s commented Dec 15, 2021 •

edited

Loading

teutat3s commented Dec 15, 2021

bahamat commented Dec 15, 2021

teutat3s commented Dec 16, 2021 •

edited

Loading

support static ip #158

Are you sure you want to change the base?

support static ip #158

Conversation

Smithx10 commented Mar 29, 2021 • edited Loading

bahamat left a comment

Choose a reason for hiding this comment

teutat3s commented Sep 1, 2021

bahamat commented Sep 1, 2021

teutat3s commented Sep 1, 2021

teutat3s commented Nov 16, 2021

teutat3s commented Nov 19, 2021 • edited Loading

bahamat commented Nov 19, 2021

teutat3s commented Dec 14, 2021

bahamat commented Dec 14, 2021

teutat3s commented Dec 15, 2021 • edited Loading

teutat3s commented Dec 15, 2021

bahamat commented Dec 15, 2021

teutat3s commented Dec 16, 2021 • edited Loading

Smithx10 commented Mar 29, 2021 •

edited

Loading

teutat3s commented Nov 19, 2021 •

edited

Loading

teutat3s commented Dec 15, 2021 •

edited

Loading

teutat3s commented Dec 16, 2021 •

edited

Loading