Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-13588] Add new field to support configuration of TYK_API_PORT #372

Merged
merged 15 commits into from
Dec 23, 2024

Conversation

komalsukhani
Copy link
Collaborator

@komalsukhani komalsukhani commented Dec 17, 2024

Description

Added new field in tyk-dashboard chart dashboard.tykApiPort to configure value of TYK_API_PORT.

Related Issue

https://tyktech.atlassian.net/browse/TT-13558
Resolves #355

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@komalsukhani komalsukhani changed the title Tt 13588/tyk api port [TT-13588] Add new field to support configuration of TYK_API_PORT Dec 17, 2024
@komalsukhani komalsukhani marked this pull request as ready for review December 17, 2024 16:57
@komalsukhani komalsukhani requested a review from a team as a code owner December 17, 2024 16:57
@komalsukhani komalsukhani requested review from olamilekan000 and removed request for a team December 17, 2024 16:57
@bojantyk bojantyk merged commit 8bb78e8 into main Dec 23, 2024
8 checks passed
@bojantyk bojantyk deleted the TT-13588/tyk_api_port branch December 23, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TYK_DB_TYKAPI_HOST and TYK_DB_TYKAPI_PORT set to wrong values when control is enabled
3 participants