Skip to content

Commit

Permalink
todos: cross-browser support and embedded version
Browse files Browse the repository at this point in the history
  • Loading branch information
Madoshakalaka committed Dec 9, 2020
1 parent 78b5e5f commit 92cc03a
Showing 1 changed file with 23 additions and 1 deletion.
24 changes: 23 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,26 @@ This loads the code generated in `./dist` as a chrome plugin.
`.eslintrc` and `.eslintignore` are both present. To lint project javascript manually,
run `npm run lint` or `$ eslint [--fix] .` under project root.

We also have a Github action that runs `eslint --fix .` and commits automatically to enforce formatting.
We also have a Github action that runs `eslint --fix .` and commits automatically to enforce formatting.

## Todo: embedded version

Goal:

so that website maintainers can include this one liner in their HTML and get click-in-text on their page:

`<script src="https://unpkg.com/cree-click-in-text"></script>`

Question:

Do we need an option/configuration page in this embedded version? Current chrome extension supports configuration by
a chrome proprietary menu, where you can set things like `translation delay`, `translation key - alt/ctrl`, `hover or click` etc.

If we do need a option page for embedded version, in what form do we present the options page? I think a hovering widget
is ideal.


## Todo: Adapt to multiple browsers

Seems like there are ways to write a cross-browser extension in one codebase,
see more at Mozilla's [Build a cross browser extension](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Build_a_cross_browser_extension)

0 comments on commit 92cc03a

Please sign in to comment.